chore: use oxfmt for formatting and sort imports #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudBarre
requested changes
Oct 23, 2025
| @@ -1,6 +1,6 @@ | |||
| import { App } from './App.tsx' | |||
There was a problem hiding this comment.
Yeah, we need to wait for proper import sorting. It looks like it's only sorting by string, so relative import comes first . < @ < a.
| import reactLogo from './react.svg' | ||
| import './App.css' | ||
| import { TitleWithExport, framework } from './TitleWithExport.tsx' | ||
| import './App.css' |
There was a problem hiding this comment.
Not really fan of plugins that re-order side-effect imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just interested to try it out since I still don't use eslint for
packages/plugin-rsc, so there's no import sorting there. It looks like the diff is only from import sorting.Probably things to check: