Skip to content

Fix test output xfail ut #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 3, 2025
Merged

Fix test output xfail ut #439

merged 5 commits into from
Nov 3, 2025
+23 −30

Conversation

@tukwila
Copy link
Contributor

@tukwila tukwila commented Oct 30, 2025

Summary

Fix two problems:

  1. UT: tests/unit/benchmark/test_output:test_file_csv is marked as fail
  2. some code quality check failure

Details

  • [ ]

Test Plan

Related Issues

  • Resolves #
  • "I certify that all code in this PR is my own, except as noted below."

Use of AI

  • Includes AI-assisted code completion
  • Includes code generated by an AI application
  • Includes AI-generated tests (NOTE: AI written tests should have a docstring that includes ## WRITTEN BY AI ##)

@tukwila
fix test_output xfail ut case
632aeae 
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@tukwila
fix some code quality check error
3fed53a 
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@tukwila
remove marker xfail
37e0c97 
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
@tukwila
Copy link
Contributor Author

tukwila commented Oct 31, 2025

@markurtz @jaredoconnell pls help to check this fix is ok?

jaredoconnell
jaredoconnell requested changes Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other changes look fine at first glance, but it fails for me due to the change to use "attributes".

@tukwila
update benchmark mocker requests
62c4a11 
Signed-off-by: guangli.bao <guangli.bao@daocloud.io>
jaredoconnell
jaredoconnell approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@jaredoconnell jaredoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ready now. Thanks for fixing the mock.

@jaredoconnell jaredoconnell merged commit 9d9392b into vllm-project:main Nov 3, 2025
14 of 17 checks passed
@tukwila tukwila deleted the fix_test_output_xfail branch November 4, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sjmonson sjmonson sjmonson approved these changes

@jaredoconnell jaredoconnell jaredoconnell approved these changes

@markurtz markurtz Awaiting requested review from markurtz

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tukwila @sjmonson @jaredoconnell