-
Notifications
You must be signed in to change notification settings - Fork 93
test(e2e): basic E2Es #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): basic E2Es #440
Conversation
jaredoconnell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. It is fairly self-contained, so it shouldn't cause any issues as long as the tests aren't flaky. Just one blocker as discussed in the call.
sjmonson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small nits
|
@sjmonson I just straight up applied all of your suggestions. |
sjmonson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more nit. Also needs signoff, E.g. git rebase --signoff main.
7ad683b to
3c0d08b
Compare
Signed-off-by: Alon Kellner <akellner@redhat.com>
3c0d08b to
ef3e541
Compare
Summary
E2E tests which check basic GuideLLM functionality, using vLLM simulator.
Details
Test Plan
Use of AI
## WRITTEN BY AI ##)