Skip to content

Conversation

@rupengliu-meta
Copy link
Contributor

Thanks to @bythew3i (Jevin) for providing the insight for the optimization. This is to skip size computation during DMA wait.

I have ran both kernel's test and brought up e2e vllm server to test, will provide perf improvement numbers

Signed-off-by: Rupeng Liu rupengliu@meta.com

Description

Start with a short description of what the PR does and how this is a change from
the past.

The rest of the description includes relevant details and context, examples:

  • why is this change being made,
  • the problem being solved and any relevant context,
  • why this is a good solution,
  • some information about the specific implementation,
  • shortcomings of the solution and possible future improvements.

If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456

Tests

Please describe how you tested this change, and include any instructions and/or
commands to reproduce.

Checklist

Before submitting this PR, please make sure:

  • I have performed a self-review of my code.
  • I have necessary comments in my code, particularly in hard-to-understand areas.
  • I have made or will make corresponding changes to any relevant documentation.

Signed-off-by: Rupeng Liu rupengliu@meta.com
Copy link
Collaborator

@kyuyeunk kyuyeunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double check, is it using same optimization as this PR? #718

Maybe we should wait until response from @lsy323 and only merge it if there is no response?

I have ran both kernel's test and brought up e2e vllm server to test, will provide perf improvement numbers

Can you provide more concrete performance number in the description?

Also, please fix pre-commit failures.

kyuyeunk added a commit that referenced this pull request Nov 19, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
kyuyeunk added a commit that referenced this pull request Nov 20, 2025
Signed-off-by: Kyuyeun Kim <kyuyeunk@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants