Skip to content

Conversation

@mikequan0425
Copy link

@mikequan0425 mikequan0425 commented Nov 3, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

这个 PR 移除了 pyproject.toml 文件中 [build-system].requires 部分的 torchtorch-npu 依赖。然而,setup.py 在构建过程中依赖 torch-npu 来查找其安装路径并配置 CMake。因此,这个改动会导致从源码分发包(sdist)构建项目时失败。为了正确移除这些依赖,setup.py 中依赖 torch-npu 的逻辑也需要被相应地修改。

@github-actions
Copy link

github-actions bot commented Nov 3, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant