[test/dnm] do not merge: ci-infra dummy PR #27749
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request appears to be for testing CI infrastructure. It introduces a change to a log message, adding a test-specific prefix. My review feedback focuses on removing this test artifact to maintain code quality, even though the pull request is marked as 'do not merge'.
| platform_cls_qualname = builtin_platform_plugins[activated_builtin_plugins[0]]() | ||
| logger.debug( | ||
| "Automatically detected platform %s.", activated_builtin_plugins[0] | ||
| "!d00d: Automatically detected platform %s.", activated_builtin_plugins[0] |
Contributor
There was a problem hiding this comment.
This log message includes the prefix !d00d:, which appears to be a temporary string for testing or debugging. Such artifacts should be removed from the codebase before merging to ensure code clarity and professionalism.
Suggested change
| "!d00d: Automatically detected platform %s.", activated_builtin_plugins[0] | |
| "Automatically detected platform %s.", activated_builtin_plugins[0] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for testing changes to the ci-infra repository. Thanks! (apologies for the noise)