[BugFix] Handle unscheduled requests properly when async scheduling #27756
+63
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
requested review from
ApostaC,
NickLucche,
WoosukKwon,
alexm-redhat,
comaniac,
heheda12345,
robertgshaw2-redhat and
ywang96
as code owners
njhill
commented
Oct 29, 2025
Comment on lines
+448
to
+450
| threshold = self.scheduler_config.long_prefill_token_threshold | ||
| if 0 < threshold < num_new_tokens: | ||
| num_new_tokens = threshold |
There was a problem hiding this comment.
Unrelated simplification, hurt me to look at that formatting :)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
njhill
commented
Oct 29, 2025
| # the request's block IDs. For those in the set, new_block_ids will be used as the | ||
| # request's block IDs instead of appending to the existing block IDs. | ||
| resumed_from_preemption: list[bool] | ||
| resumed_req_ids: set[str] |
There was a problem hiding this comment.
Changing this to a set since these will be rare and we currently are creating a [None] * batch_size list every time.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Nick Hill <nhill@redhat.com>
Signed-off-by: Nick Hill <nhill@redhat.com>
njhill
added
suppress-bc-linter
ready
|
This pull request has merge conflicts that must be resolved before it can be |
# Conflicts: # vllm/distributed/kv_transfer/kv_connector/v1/shared_storage_connector.py
5 tasks
njhill
commented
Oct 30, 2025
Comment on lines
+120
to
+131
| @cached_property | ||
| @deprecated("use resumed_req_ids field") | ||
| def resumed_from_preemption(self) -> list[bool]: | ||
| return [req_id in self.resumed_req_ids for req_id in self.req_ids] | ||
|
|
||
| @cached_property | ||
| @deprecated("use all_token_ids field") | ||
| def resumed_req_token_ids(self) -> list[list[int] | None]: | ||
| return [ | ||
| self.all_token_ids[req_id] if req_id in self.resumed_req_ids else None | ||
| for req_id in self.req_ids | ||
| ] |
There was a problem hiding this comment.
These are for backwards compatibility.
benchislett
approved these changes
Oct 30, 2025
|
For follow-on:
|
MatthewBonanni
pushed a commit
to MatthewBonanni/vllm
that referenced
this pull request
Oct 30, 2025
…llm-project#27756) Signed-off-by: Nick Hill <nhill@redhat.com>
adobrzyn
added a commit
to vllm-project/vllm-gaudi
that referenced
this pull request
Oct 31, 2025
…equests properly when async scheduling #27756 (#507) Culprit commit: vllm-project/vllm#27756 --------- Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai> Signed-off-by: Michał Kuligowski <michal.kuligowski@intel.com> Signed-off-by: Agata Dobrzyniewicz <160237065+adobrzyn@users.noreply.github.com> Co-authored-by: Michał Kuligowski <michal.kuligowski@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There may be circumstances other then preemption where a running request is temporarily not scheduled in the batch for some step(s). These need to be handled similarly to the async scheduling + preemption fix made in #26385.
This PR also streamlines how resumed requests are recorded in
CachedRequestData.