Reapply "Install pre-built xformers-0.0.32.post2 built with pt-2.9.0" #27768
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reapplies the installation of a pre-built xformers wheel, removing the previous build-from-source step in the Dockerfile. However, there appears to be a critical version mismatch in the xformers dependency specified in requirements/cuda.txt. The version in the file does not match the version mentioned in the pull request description, which was specifically added to fix a build failure. This should be corrected to ensure the build works as intended.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…vllm-project#27714) This reverts commit 9007bf5. Signed-off-by: Huy Do <huydhn@gmail.com>
Signed-off-by: Huy Do <huydhn@gmail.com>
huydhn
force-pushed
the
reland-use-prebuilt-xformers
branch
from
6f07867 to
145906b
Compare
github-actions
bot
added
the
ready
Head branch was pushed to by a user without write access
|
Sorry to interrupt, unblock language-models-test-extended-pooling expect this PR to fix the main failure, but it didn't. (This failure might not be related to xformers.) |
It makes sense that they are not related. This PR just swaps in a prebuilt |
I don't know why #27659 can succeed; what is the subtle difference between it and the main requirements? https://buildkite.com/vllm/ci/builds/36673/steps/canvas?sid=019a2cf2-4410-4d56-9eec-27dd93dfe177 |
|
@simon-mo I think those failures are the same nightly failures from before while https://buildkite.com/vllm/release/builds/9677 looks ok now |
3 participants
Purpose
This relands #27598 exactly as it is. For the CUDA 13.0 build failure in https://buildkite.com/vllm/release/builds/9637#019a3162-f87b-4fd4-820a-5612913b590e, I have added the missing xformers wheel for cu130 at https://download.pytorch.org/whl/cu130/xformers-0.0.33%2B5d4b92a5.d20251029-cp39-abi3-linux_x86_64.whl
Test Plan
https://buildkite.com/vllm/release/builds/9672 should all be green
@simon-mo