Crashfix with underwater giant NavMesh#3149
Closed
Wall-core wants to merge 1 commit intovmangos:developmentfrom
Closed
Crashfix with underwater giant NavMesh#3149Wall-core wants to merge 1 commit intovmangos:developmentfrom
Wall-core wants to merge 1 commit intovmangos:developmentfrom
Conversation
Fixes a dereferenced null pointer
Contributor
|
Did you actually get a crash here? Cause if IsCreature is true then pUnit can't be null, because all creatures are units, it's their base class. |
Contributor
Author
|
frankly I'm not sure, I'm helping debug AshenWoW and don't have a stack trace but there's a crash occurring somewhere in findRandomPointAroundCircle, according to the crashlog: 
so I just browsed through these associated functions and my visual studio was throwing a warning for dereferenced null pointer, which I dealt with here. I'll be helping them rebuild with gdb this week so I can get an actual stack trace, but if you want to investigate further, here is an additional crashlog (same problem): 
|
Contributor
|
Oh I know what causes this. You need to set CleanupTerrain to 0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a dereferenced unit pointer crash