Skip to content

[DVPS] Windows compatility#7

Open
puremana wants to merge 2 commits intovmeow:masterfrom
puremana:windows-compatibility
Open

[DVPS] Windows compatility#7
puremana wants to merge 2 commits intovmeow:masterfrom
puremana:windows-compatibility

Conversation

@puremana
Copy link
Copy Markdown
Collaborator

@puremana puremana commented Jul 9, 2019

Not sure if you wanted this in master, but I figured windows compatibility for master needs to happen at some point

Feel free to decline

@vmeow
Copy link
Copy Markdown
Owner

vmeow commented Jul 9, 2019

I'm reluctant to pull in these changes because at that point it makes the project Windows-specific only and devs will have to edit the Gemfile to do work.

I need to investigate handling different OS's, and installing separate gems depending on that.

Notes to self:

@puremana
Copy link
Copy Markdown
Collaborator Author

puremana commented Jul 9, 2019

Made a change, checking for windows in gemfile using if (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RUBY_PLATFORM) != nil

should work if we aren't using jruby. Problem is there are always going to be different gemfile.lock files being committed from windows and other developers

let me know what you think

@vmeow
Copy link
Copy Markdown
Owner

vmeow commented Jul 10, 2019

Maybe I should Dockerize this?

I tried to set up on a different Windows machine than I originally created this branch off of. I keep running into new issues that I didn't run into on my original Windows machine.

Probably less work for both myself and future/current devs, honestly

@vmeow
Copy link
Copy Markdown
Owner

vmeow commented Jul 10, 2019

Alternatively, I don't see there being new gems added often; maybe we can .gitignore the Gemfile and Gemfile.lock and just have separate files for different environments.

@puremana
Copy link
Copy Markdown
Collaborator Author

Alternatively, I don't see there being new gems added often; maybe we can .gitignore the Gemfile and Gemfile.lock and just have separate files for different environments.

That's another solution, up to you man

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants