Skip to content

Update VMTK tag for vtkAddon wrapper files.#163

Merged
chir-set merged 1 commit intovmtk:masterfrom
chir-set:UpdateVMTK
Aug 20, 2025
Merged

Update VMTK tag for vtkAddon wrapper files.#163
chir-set merged 1 commit intovmtk:masterfrom
chir-set:UpdateVMTK

Conversation

@chir-set
Copy link
Copy Markdown
Collaborator

Python wrapper files in vtkAddon have been updated for VTK 9.5.

Updated files in vtkAddon:

vtkMacroKitPythonWrap.cmake
vtkWrapHierarchy.cmake
vtkWrapPython.cmake.

Python wrapper files in vtkAddon have been updated for VTK 9.5.
@chir-set chir-set merged commit 2015de3 into vmtk:master Aug 20, 2025
@chir-set chir-set deleted the UpdateVMTK branch August 20, 2025 09:28
@lassoan
Copy link
Copy Markdown
Contributor

lassoan commented Aug 20, 2025

Thank you! The windows and macos dashboard looks good now (there is only a small syntax error that I've fixed). There was still a build error in linux that I've tried to address here - we'll see tomorrow if the fix works.

@chir-set
Copy link
Copy Markdown
Collaborator Author

we'll see tomorrow if the fix works.

For a successful build on Linux (Slicer 399ee32a7, VMTK 6bfad0f0, SlicerVMTK 71f2f00), I had to replace this line in vtkAddon by find_package(Python3 COMPONENTS Development).

Thank you for this insight from VMTK 6bfad0f0.
I would not have thought that we just have to cascade the find_package(Python3) semantics.

@lassoan
Copy link
Copy Markdown
Contributor

lassoan commented Aug 20, 2025

Great, we are getting close!

I had to replace this line in vtkAddon by find_package(Python3 COMPONENTS Development).

Could you submit a PR to vtkAddon to fix this?

@chir-set
Copy link
Copy Markdown
Collaborator Author

Could you submit a PR to vtkAddon to fix this?

The PR is here.

If it's merged, I'll send one to update VMTK accordingly, and a last one for SlicerVMTK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants