-
Notifications
You must be signed in to change notification settings - Fork 12
Improve upgrade doc #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PavitraS
wants to merge
24
commits into
main
Choose a base branch
from
dm-upgrade-doc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Improve upgrade doc #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nexus node spec updates made by users may result in backward incompatibility. User should be able to upgrade datamodel based on the force flag and observe the incompatible changes This PR calls common-library to see if the old and new crd have undergone any modifications, and if there have been any incompatible changes - Compiler should iterate through all created datamodel objects to ensure backward compatibility - If there are incompatible modifications and the force flag is enabled, the message notice will be logged in the console - If the force flag is deactivated and there are incompatible changes, the operation should fail with incompatible errors
856457c to
0ce36c4
Compare
bab97e2 to
4293d5d
Compare
4293d5d to
f28b492
Compare
7509b66 to
63844b9
Compare
688b86d to
210c3b8
Compare
210c3b8 to
c10d670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.