NPT-799 fix for issue when the first query with root-Id gets panic#119
Open
vipinakavarpu wants to merge 1 commit intomainfrom
Open
NPT-799 fix for issue when the first query with root-Id gets panic#119vipinakavarpu wants to merge 1 commit intomainfrom
vipinakavarpu wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The initialization of nexus client was being performed in the getRootResolver and this lead to cache miss when user invokes the query for the first time. The object returned is nil in this scenario and no check was performed before try to access object's variable thus causing the panic. The fix is to disconnect the initialization of nexus client logic from root resolver func and create separate init method to invoke it at the start of the server. Also added check for nil for root object being returned.