🌱 Clean up volume batch error messages#1426
Open
bryanv wants to merge 1 commit intovmware-tanzu:mainfrom
Open
Conversation
There are various possible when building the batch spec, but some of the messages weren't formatted great, like: failed to build volume specs: waiting for the device controller \"SCSI\" '\\x01' to be created for volume where the bus number gets printed in hex. Also apply a little consistency and don't quote the volume name. If there are multiple errors, note that they all get prefixed with "failed to build volume specs:" but leave that for later.
dilyar85
approved these changes
Jan 28, 2026
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
There are various possible when building the batch spec, but some of the messages weren't formatted great, like:
failed to build volume specs: waiting for the device controller
"SCSI" '\x01' to be created for volume
where the bus number gets printed in hex. Also apply a little consistency and don't quote the volume name.
If there are multiple errors, note that they all get prefixed with "failed to build volume specs:" but leave that for later.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: