refactor: quoting style in .goreleaser.yml #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-review
There was a problem hiding this comment.
Pull request overview
This PR aims to standardize quoting style in the .goreleaser.yml configuration file by converting double quotes to single quotes for improved readability and consistency. However, the changes introduce critical syntax errors that would break the build configuration.
Changes:
- Updated string values to use single quotes in build configurations for mod_timestamp, ldflags, binary name templates, and goarch values
- Updated archive and checksum name templates to use single quotes
- Removed an inline comment from the ignore section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tenthirtyam
force-pushed
the
refactor/release-quoting
branch
from
c2ba96f to
690a7ce
Compare
Updated the .goreleaser.yml file to consistently use single quotes for string values, improving readability and maintaining YAML style consistency across build, archive, and checksum configurations. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
tenthirtyam
force-pushed
the
refactor/release-quoting
branch
from
690a7ce to
24ffd9c
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the .goreleaser.yml file to consistently use single quotes for string values, improving readability and maintaining YAML style consistency across build, archive, and checksum configurations.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Additional Information