Fixes #29 - Remove old hyperlink detectors

[vogella]

This PR fixes #29 by removing the old hyperlink detectors from the editor plugin. The hyperlink detection is now handled by the LSP server.

[gemini-code-assist]

Summary of Changes

Hello @vogella, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the Asciidoc editor plugin by migrating its hyperlink detection and hover provider capabilities to a Language Server Protocol (LSP) server. This change streamlines the plugin's architecture, eliminating redundant custom implementations and centralizing language-specific features within the LSP framework. The result is a cleaner, more maintainable codebase that leverages a standardized approach for editor functionalities.

Highlights

• Refactoring Hyperlink Detection: The pull request removes the custom hyperlink detection logic from the Asciidoc editor plugin, as this functionality is now handled by the Language Server Protocol (LSP) server.
• Removal of Custom Hover Provider: The custom image hover provider, previously implemented in the editor plugin, has also been removed, aligning with the shift to LSP-based language features.
• Codebase Simplification: Several Java classes responsible for the old hyperlink detection and resource handling, along with their corresponding extension points in plugin.xml, have been deleted, simplifying the plugin's codebase.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes the old hyperlink detectors and hover providers from the editor plugin, migrating the functionality to the LSP server as intended. The changes are clean and focused.

However, the PR is incomplete and will break the build:

• The test file com.vogella.ide.editor.asciidoc.tests/src/com/vogella/ide/editor/asciidoc/tests/IncludeHyperlinkDetectorTests.java corresponds to the now-deleted IncludeHyperlinkDetector.java. It must be removed to prevent compilation errors. This is a critical issue.

Additionally, there is some leftover dead code that should be cleaned up as part of this change. I've added a specific comment on that. Please address these points to complete the refactoring.