Conversation
srcpkgs/gdnsd/template
Outdated
| --disable-silent-rules | ||
| --with-rundir=/run/gdnsd" | ||
| hostmakedepends="automake pkg-config" | ||
| makedepends="libunwind-devel libmaxminddb-devel perl xz |
There was a problem hiding this comment.
perl and xz in makedepends seems wrong, since its not failing to build it seems like they are not required. And if they would be required they wouldn't be executable during cross builds.
packages that need to be executed during the build process should be in hostmakedepends and since perl and xz aren't -devel packages that would be used during the build process for linking I'm not sure why they are there.
There was a problem hiding this comment.
perl is listed as required in the configure.ac: https://github.com/gdnsd/gdnsd/blob/eefb032e171ed2f6f20b93cdcc09b04d0e45e78d/configure.ac#L254-L262
xz is also, but it says that it's used for tests, which we're disabling anyways, so it makes sense to remove that.
There was a problem hiding this comment.
Ok, it worked before because automake in hostmakedepends depends on perl so it was implictly pulled into hostmakedepends, but now its more correct and avoids installing perl needlessly for the target architecture.
jailbird777
force-pushed
the
gdnsd
branch
2 times, most recently
from
f7ac3b1 to
6c7d55e
Compare
srcpkgs/gdnsd/template
Outdated
| _gdnsd_homedir="/var/lib/gdnsd" | ||
|
|
||
| make_dirs="/var/lib/gdnsd 0750 _gdnsd _gdnsd | ||
| /etc/gdnsd 0750 _gdnsd _gdnsd" |
There was a problem hiding this comment.
Does the user _gdnsd really need write permissions here (/etc/gdnsd)?
There was a problem hiding this comment.
Good point. I fixed that, and while I was at it, changed the home dir to /var/empty
srcpkgs/gdnsd/template
Outdated
| checksum=16a81836273dcbc17e5527df2214e8664d0545bb18b55f08325710de10c8f64d | ||
|
|
||
| system_accounts="_gdnsd" | ||
| _gdnsd_homedir="/var/empty" |
There was a problem hiding this comment.
Thats the default so it can be removed.
| _gdnsd_homedir="/var/empty" |
There was a problem hiding this comment.
Done! Thanks for all of the help!
srcpkgs/gdnsd/template
Outdated
|
|
||
| system_accounts="_gdnsd" | ||
|
|
||
| make_dirs="/etc/gdnsd 0550 _gdnsd _gdnsd" |
There was a problem hiding this comment.
No wait this is not what i was thinking, Generally we keep the root user the owner and the less privileged users group the group so that its able to read the file, but not edit, while root doesn't get bothered.
Assuming it contains secrets, otherwise just changing the owner or making this unreadable by others doesn't make sense.
There was a problem hiding this comment.
Makes sense!
make_dirs="/etc/gdnsd 0750 root _gdnsd"
Sound better?
3 participants
Testing the changes
New package
Local build testing