Skip to content

New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2#58994

Open
kalelidev wants to merge 4 commits intovoid-linux:masterfrom
kalelidev:sstp-client
Open

New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2#58994
kalelidev wants to merge 4 commits intovoid-linux:masterfrom
kalelidev:sstp-client

Conversation

@kalelidev
Copy link
Copy Markdown
Contributor

@kalelidev kalelidev commented Feb 14, 2026

This adds the SSTP client from https://gitlab.com/sstp-project/sstp-client.

This adds support for the SSTP VPN plugin in NetworkManager from https://gitlab.gnome.org/GNOME/network-manager-sstp.

  • sstp-client-1.0.20: Base SSTP VPN client.
  • network-manager-sstp-1.3.2: NetworkManager plugin for SSTP, depends on sstp-client.
    Includes patch to fix obsolete GTK4 spacing in UI generation.

Combined into one PR to resolve dependency for CI/build.

Shared library registration
Added to common/shlibs:

Testing the changes
I tested the changes in this PR: YES
New package
This new package conforms to the package requirements: YES
Local build testing
I built this PR locally for my native architecture, x86_64-glibc
I built this PR locally for these architectures:
aarch64 (cross)

@tranzystorekk tranzystorekk added the new-package This PR adds a new package label Feb 14, 2026
@kalelidev kalelidev marked this pull request as ready for review February 14, 2026 19:09
@kalelidev kalelidev force-pushed the sstp-client branch 2 times, most recently from 815cad7 to 4cf70c7 Compare February 16, 2026 23:33
@Duncaen
Copy link
Copy Markdown
Member

Duncaen commented Feb 17, 2026

Since this depends on another new package in a separate pull request you should put them together in one request so that CI can build it and merging doesn't require merging two separate PRs.

@kalelidev
Copy link
Copy Markdown
Contributor Author

Since this depends on another new package in a separate pull request you should put them together in one request so that CI can build it and merging doesn't require merging two separate PRs.

Thanks for the heads-up.
You're right that it depends on another new package from a separate PR, but I don't recall opening another simultaneous PR for the dependency—could you let me know which PR number you're referring to (#XXXXX?) so I can check and fix it?
If needed, I'll close this one and combine them into a single PR so the CI can build everything without issues. Just let me know.

@Duncaen
Copy link
Copy Markdown
Member

Duncaen commented Feb 17, 2026

I meant to comment this in #59016, since that one depends on this PR.

@kalelidev kalelidev changed the title New package: sstp-client-1.0.20 New packages: sstp-client-1.0.20 and network-manager-sstp-1.3.2 Feb 21, 2026
@kalelidev
Copy link
Copy Markdown
Contributor Author

I meant to comment this in #59016, since that one depends on this PR.

@Duncaen Thanks for the heads-up earlier!

I've now combined both packages into this PR (#58994):

  • Added sstp-client-1.0.20 (already there)
  • Added network-manager-sstp-1.3.2 with GTK4 spacing fix patch
  • Included the GNOME subpackage as symlink (standard for NM plugins)

Closed the separate #59016.

CI should now build everything together without dependency issues.
Let me know if the patch needs tweaks or if there's anything else!

--with-gnome
--with-gtk4
--disable-gtk-doc
--disable-static"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove --prefix and --libdir, those are set already by the gnu-configure buildstyle.
Indent wtih a single space inside of variables.

Comment on lines +34 to +35
find "${DESTDIR}" -name '*.la' -delete
find "${DESTDIR}" -name '*.a' -delete
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
find "${DESTDIR}" -name '*.la' -delete
find "${DESTDIR}" -name '*.a' -delete
find "${DESTDIR}" \( -name '*.la' -o -name '*.a' \) -delete


hostmakedepends="pkg-config libtool"
makedepends="ppp-devel libevent-devel openssl-devel"
depends="ppp ca-certificates"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move all those standard dependency variables above short_desc

You can use xnew pkgname from the xtools package to create a new empty template file next time so that variables are ordered consistently.

makedepends="NetworkManager-devel glib-devel gnutls-devel gtk+3-devel gtk4-devel libnma-devel libsecret-devel ppp-devel sstp-client-devel"

depends="NetworkManager sstp-client"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all the empty lines between variables here.

@Duncaen
Copy link
Copy Markdown
Member

Duncaen commented Mar 14, 2026

network-manager-sstp needs to run gtk4-builder-tool, so it needs gtk4-devel in hostmakedepends too for cross compilation to work.

https://github.com/void-linux/void-packages/actions/runs/22270286827/job/67089648439?pr=58994#step:7:786

Copy link
Copy Markdown
Member

@Duncaen Duncaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits so that its one commit per package.

pkgname=network-manager-sstp
version=1.3.2
revision=1
_extraver=-1
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For something like this we usually replace - in the version with something like 1.3.2pl1 and the use `${version/pl/-} for for the distfiles url.

hostmakedepends="pkg-config intltool autoconf automake libtool gettext-devel-tools glib-devel gtk4-devel"
makedepends="NetworkManager-devel glib-devel gnutls-devel gtk+3-devel gtk4-devel libnma-devel libsecret-devel ppp-devel sstp-client-devel"

depends="NetworkManager sstp-client"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xbps-src automatically detects linked dependencies and adds minimum version requirements based on the shared libraries recorded in common/shlibs:

https://github.com/void-linux/void-packages/actions/runs/23329624872/job/67935137374?pr=58994#step:7:1214

Remove sstp-client here since its automatically added with the minimum version constraint.

This is also applies for the other packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants