Skip to content

common/build-helper/rust.sh: use SODIUM_USE_PKG_CONFIG, pijul: update…#59489

Closed
jrvieira wants to merge 1 commit intovoid-linux:masterfrom
jrvieira:fix-rust-sh-sodium
Closed

common/build-helper/rust.sh: use SODIUM_USE_PKG_CONFIG, pijul: update…#59489
jrvieira wants to merge 1 commit intovoid-linux:masterfrom
jrvieira:fix-rust-sh-sodium

Conversation

@jrvieira
Copy link
Copy Markdown

common/build-helper/rust.sh: use SODIUM_USE_PKG_CONFIG, pijul: update to 1.0.0.beta.9

Fixes #59131

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, x86_64

@classabbyamp
Copy link
Copy Markdown
Member

does this change to the build helper break (or remove the dependency on libsodium) any of the other rust packages that use libsodium?

garage
rdedup
python3-etebase
gst-plugins-rs1

@jrvieira
Copy link
Copy Markdown
Author

No.

gst-plugins-rs1 fails with an unrelated pre-existing compiler error (implicit autoref in audioloudnorm/imp.rs), confirmed to also fail on unmodified upstream master.

@classabbyamp
Copy link
Copy Markdown
Member

can you split this into 2 commits, one for the build helper change and one for the update?

@jrvieira jrvieira closed this by deleting the head repository Mar 22, 2026
@classabbyamp
Copy link
Copy Markdown
Member

you don't need to close it, you can just remake the commits and force-push

@jrvieira
Copy link
Copy Markdown
Author

Sorry, i'm not used to github. This PR is replaced by #59527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rust.sh: SODIUM_LIB_DIR conflicts with libsodium-sys's use-pkg-config feature

2 participants