-
Notifications
You must be signed in to change notification settings - Fork 16
[Governance] Update volcano community coc, use reference to CNCF #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @kevin-wangzefeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Volcano community's Code of Conduct to streamline its maintenance and improve clarity for community members. The changes involve adopting a direct reference to the CNCF Code of Conduct, establishing a clear reporting mechanism for violations, and standardizing the filename for better consistency. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great improvement, simplifying the community's Code of Conduct by referencing the CNCF's official document and providing a clear contact for reporting violations. The file rename to CODE_OF_CONDUCT.md also aligns with common repository conventions. I have one minor suggestion to update the branch name in the link for better long-term maintainability. Additionally, you might want to check for other references to the old Code of Conduct file in the repository, such as in GOVERNANCE.md, and update them in a separate change to prevent broken links.
instead of maintaining copy of the file content. Also added email address to define who will be handling the issue if any unacceptable behavior occurs. Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
…ention Signed-off-by: Kevin Wang <kevinwzf0126@gmail.com>
3e9a01a to
4eb8e0a
Compare
|
/lgtm Please help merge it thanks @hzxuzhonghu |
|
@kevin-wangzefeng As in https://github.com/cncf/toc/blob/main/.github/ISSUE_TEMPLATE/template-graduation-application.md#governance-and-maintainers required, |
hzxuzhonghu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: #105
This PR includes the following changes to our community code of conduct:
Signed-off-by: Kevin Wang kevinwzf0126@gmail.com