Skip to content

Conversation

@yaozheng-fang
Copy link
Collaborator

  1. add veadk init command in CLI module
  2. remove templated vefaas project to cli/services/vefaas/template to make project more modulized

@yaozheng-fang yaozheng-fang requested a review from cuericlee August 4, 2025 05:49
@cuericlee cuericlee requested a review from Copilot August 4, 2025 05:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the veadk init command in the CLI module and reorganizes the VeFaaS project template structure. The changes include adding support for remote VE agents and improving modularity by moving template files to a dedicated CLI services directory.

  • Added support for RemoteVeAgent in the Runner class with conditional handling
  • Created a complete VeFaaS project template with deployment scripts and configuration
  • Updated documentation to include A2A agent usage examples

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
veadk/runner.py Modified to support both Agent and RemoteVeAgent types with conditional long-term memory handling
veadk/cli/services/vefaas/template/src/run.sh Added deployment script for VeFaaS projects with configurable host/port settings
veadk/cli/services/vefaas/template/src/requirements.txt Created requirements file with VeADK dependencies
veadk/cli/services/vefaas/template/src/config.py Added configuration template with agent setup and tracer configurations
veadk/cli/services/vefaas/template/src/app.py Created FastAPI application entry point for VeFaaS deployment
veadk/cli/services/vefaas/template/deploy.py Added deployment script using CloudAgentEngine
veadk/cli/services/vefaas/template/config.yaml.example Created example configuration for model and credentials
veadk/cli/services/vefaas/template/README.md Added documentation for the VeFaaS template project
veadk/a2a/remote_ve_agent.py Implemented RemoteVeAgent class for A2A protocol communication
docs/docs/agent.md Updated documentation with A2A agent usage examples

agent_card_object = AgentCard.model_validate_json(str(agent_card_json_str))

super().__init__(
name=name, description="weather reporter", agent_card=agent_card_object
Copy link

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded description 'weather reporter' should be made configurable or derived from the agent card to make this class more generic and reusable.

Suggested change
name=name, description="weather reporter", agent_card=agent_card_object
name=name, description=agent_card_dict.get("description", ""), agent_card=agent_card_object

Copilot uses AI. Check for mistakes.

## Deploy

We recommand you deploy this project by the `cloud` module of VeADK.
Copy link

Copilot AI Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling error: 'recommand' should be 'recommend'.

Suggested change
We recommand you deploy this project by the `cloud` module of VeADK.
We recommend you deploy this project by the `cloud` module of VeADK.

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@cuericlee cuericlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcengine volcengine deleted a comment from Copilot AI Aug 4, 2025
@volcengine volcengine deleted a comment from Copilot AI Aug 4, 2025
@yaozheng-fang yaozheng-fang merged commit 309630c into main Aug 4, 2025
6 checks passed
@yaozheng-fang yaozheng-fang deleted the feat/veadk-init branch August 14, 2025 02:23
yaozheng-fang added a commit that referenced this pull request Aug 15, 2025
* feat: add remote agent

* feat: add veadk init command in CLI

* fix: fix typos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants