-
Notifications
You must be signed in to change notification settings - Fork 44
feat: add veadk init command in CLI module
#10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the veadk init command in the CLI module and reorganizes the VeFaaS project template structure. The changes include adding support for remote VE agents and improving modularity by moving template files to a dedicated CLI services directory.
- Added support for
RemoteVeAgentin the Runner class with conditional handling - Created a complete VeFaaS project template with deployment scripts and configuration
- Updated documentation to include A2A agent usage examples
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| veadk/runner.py | Modified to support both Agent and RemoteVeAgent types with conditional long-term memory handling |
| veadk/cli/services/vefaas/template/src/run.sh | Added deployment script for VeFaaS projects with configurable host/port settings |
| veadk/cli/services/vefaas/template/src/requirements.txt | Created requirements file with VeADK dependencies |
| veadk/cli/services/vefaas/template/src/config.py | Added configuration template with agent setup and tracer configurations |
| veadk/cli/services/vefaas/template/src/app.py | Created FastAPI application entry point for VeFaaS deployment |
| veadk/cli/services/vefaas/template/deploy.py | Added deployment script using CloudAgentEngine |
| veadk/cli/services/vefaas/template/config.yaml.example | Created example configuration for model and credentials |
| veadk/cli/services/vefaas/template/README.md | Added documentation for the VeFaaS template project |
| veadk/a2a/remote_ve_agent.py | Implemented RemoteVeAgent class for A2A protocol communication |
| docs/docs/agent.md | Updated documentation with A2A agent usage examples |
veadk/a2a/remote_ve_agent.py
Outdated
| agent_card_object = AgentCard.model_validate_json(str(agent_card_json_str)) | ||
|
|
||
| super().__init__( | ||
| name=name, description="weather reporter", agent_card=agent_card_object |
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hardcoded description 'weather reporter' should be made configurable or derived from the agent card to make this class more generic and reusable.
| name=name, description="weather reporter", agent_card=agent_card_object | |
| name=name, description=agent_card_dict.get("description", ""), agent_card=agent_card_object |
|
|
||
| ## Deploy | ||
|
|
||
| We recommand you deploy this project by the `cloud` module of VeADK. |
Copilot
AI
Aug 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error: 'recommand' should be 'recommend'.
| We recommand you deploy this project by the `cloud` module of VeADK. | |
| We recommend you deploy this project by the `cloud` module of VeADK. |
cuericlee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
* feat: add remote agent * feat: add veadk init command in CLI * fix: fix typos
veadk initcommand in CLI module