Skip to content

Conversation

@yaozheng-fang
Copy link
Collaborator

No description provided.

@yaozheng-fang yaozheng-fang requested a review from zakahan August 7, 2025 13:04
@yaozheng-fang yaozheng-fang marked this pull request as draft August 7, 2025 13:15
Copy link
Collaborator

@cuericlee cuericlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@zakahan
Copy link
Collaborator

zakahan commented Aug 11, 2025

fix todo

  • veadk/database/database_adapter.py
    • VectorDatabaseAdapter, The query function has been confirmed to not require validation and will return [] (because a not exists judgment mechanism is designed at a lower level).
    • vector: the _validate_index has been added, and the document link has also been added.
    • viking's _validate is the same as above
    • viking-mem's _validate is the same as above
    • viking's get_or_create_collection function. After creating the collection, you need to wait for a while. The subsequent while loop is used to check if the creation was successful.
    • the query of viking directly returns []
    • viking-mem, add function parameter user_id
  • veadk/database/viking/viking_memory_db.py, code source comments have been added
  • veadk/knowledgebase/knowledgebase.py added type checking for non-viking cases

fix dependency issue of database

@yaozheng-fang yaozheng-fang marked this pull request as ready for review August 11, 2025 01:57
@yaozheng-fang yaozheng-fang merged commit ad8dc62 into main Aug 11, 2025
10 checks passed
@yaozheng-fang yaozheng-fang deleted the refine/logs branch August 14, 2025 02:23
yaozheng-fang added a commit that referenced this pull request Aug 15, 2025
* refine knowledgebase and memory logs

* fix index error

* reconstruct database adapter

* update naming

* fix: fix todo

* fix: fix database dpendency issues

---------

Co-authored-by: hanzhi.421 <hanzhi.421@bytedance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants