Conversation
|
You might want to rebase, and then you can get local previews using |
d0ece9c to
d4cb849
Compare
4cee32e to
21c6e6e
Compare
|
I noticed that both footnotes and syntax highlighting seem to not be supported. Edit: Syntax highlighting PR #17 |
gatesn
left a comment
There was a problem hiding this comment.
I'm not sure what this RFC is proposing...
I think what is being proposed already exists on develop, and the unresolved questions remain unresolved?
|
I think this is really just background, we can update this as we figure out more of the unresolved questions. |
|
Yeah makes sense, I couldn't tell if the unresolved questions were supposed to remain unresolved or be answered before approving the RFC |
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
b0fc69f to
913fa41
Compare
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
|
can we merge this to the proposed directory? We know that we will be iterating on this, and I don't think it is useful to try and do that in this PR (unless there is something that seems incorrect right now). |
Rendered
This RFC proposes extending the
ExtVTabletrait to support richer behavior for extension types beyond forwarding to the storage type.It covers the already completed vtable infrastructure, the proposed trait design for types/scalars/arrays, and identifies open questions around the extension array API and compute dispatch.
The big open question here is if we need to do this at all. And if we do need to do this, what should the extension array API look like? Importantly, how should we define expressions over extension type arrays?