-
Notifications
You must be signed in to change notification settings - Fork 97
chore: canonical fallible #5598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Resolve conflicts keeping VortexResult return types for: - validity_mask() - to_canonical() - is_valid(), all_valid(), all_invalid() Adopt develop's rename from execute() to batch_execute() and ExecutionCtx parameter changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update scalar_fn vtable (canonical.rs, validity.rs) to return VortexResult - Update decompress.rs to return VortexResult<PrimitiveArray> - Add .unwrap() to test code calling decompress_into_array - Fix batch_execute method name and signature in bitpacking vtable - Update tests to handle is_valid returning VortexResult 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Deploying vortex-bench with
|
| Latest commit: |
eedbec1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9caf9f0c.vortex-93b.pages.dev |
| Branch Preview URL: | https://ji-canon-result.vortex-93b.pages.dev |
CodSpeed Performance ReportMerging #5598 will degrade performances by 27.33%Comparing Summary
Benchmarks breakdown
Footnotes
|
- Use vortex_expect in benchmarks for append_to_builder and to_canonical - Convert simple tests to return VortexResult<()> where appropriate - Add VortexExpect/VortexResult imports where needed 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
No description provided.