Skip to content

Conversation

@joseph-isaacs
Copy link
Contributor

No description provided.

joseph-isaacs and others added 5 commits November 28, 2025 16:35
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Resolve conflicts keeping VortexResult return types for:
- validity_mask()
- to_canonical()
- is_valid(), all_valid(), all_invalid()

Adopt develop's rename from execute() to batch_execute() and
ExecutionCtx parameter changes.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Update scalar_fn vtable (canonical.rs, validity.rs) to return VortexResult
- Update decompress.rs to return VortexResult<PrimitiveArray>
- Add .unwrap() to test code calling decompress_into_array
- Fix batch_execute method name and signature in bitpacking vtable
- Update tests to handle is_valid returning VortexResult

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Dec 1, 2025

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: eedbec1
Status: ✅  Deploy successful!
Preview URL: https://9caf9f0c.vortex-93b.pages.dev
Branch Preview URL: https://ji-canon-result.vortex-93b.pages.dev

View logs

@joseph-isaacs joseph-isaacs changed the title wip chore: canonical fallible Dec 1, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 1, 2025

CodSpeed Performance Report

Merging #5598 will degrade performances by 27.33%

Comparing ji/canon-result (8068211) with develop (89b236b)

Summary

❌ 59 regressions
✅ 1099 untouched
⏩ 617 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
decompress_alp[f32, (1000, 0.01, 0.25)] 12.5 µs 14.1 µs -10.87%
decompress_alp[f32, (1000, 0.01, 0.95)] 12.4 µs 13.9 µs -10.62%
decompress_alp[f32, (1000, 0.01, 1.0)] 12.2 µs 13.7 µs -10.75%
decompress_alp[f32, (1000, 0.1, 0.25)] 12.4 µs 13.9 µs -10.58%
patched_take_10_contiguous 31.6 µs 35.6 µs -11.33%
null_count_run_end[(10000, 1024, 0.01)] 2.9 µs 3.3 µs -10.72%
null_count_run_end[(10000, 256, 0.01)] 3 µs 3.3 µs -10.62%
null_count_run_end[(100000, 1024, 0.01)] 3 µs 3.3 µs -10.62%
bench_compare_primitive[(10000, 128)] 127.9 µs 147.5 µs -13.31%
bench_compare_primitive[(10000, 2)] 125 µs 144.7 µs -13.6%
bench_compare_primitive[(10000, 2048)] 157.1 µs 176.8 µs -11.15%
bench_compare_primitive[(10000, 32)] 125.7 µs 145.3 µs -13.48%
bench_compare_primitive[(10000, 4)] 125.3 µs 145 µs -13.54%
bench_compare_primitive[(10000, 512)] 138.2 µs 157.8 µs -12.44%
bench_compare_primitive[(10000, 8)] 126.1 µs 145.8 µs -13.48%
bench_compare_primitive[(100000, 128)] 453.5 µs 623.1 µs -27.22%
bench_compare_primitive[(100000, 2)] 451.6 µs 621.2 µs -27.31%
bench_compare_primitive[(100000, 2048)] 525.8 µs 695.5 µs -24.39%
bench_compare_primitive[(100000, 32)] 451 µs 620.6 µs -27.33%
bench_compare_primitive[(100000, 4)] 451.3 µs 620.9 µs -27.32%
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Footnotes

  1. 617 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 92.08989% with 176 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.66%. Comparing base (89b236b) to head (8068211).

Files with missing lines Patch % Lines
...rtex-array/src/arrays/scalar_fn/vtable/validity.rs 0.00% 19 Missing ⚠️
vortex-array/src/arrays/listview/tests/filter.rs 0.00% 16 Missing ⚠️
vortex-array/src/arrays/varbin/compute/take.rs 11.11% 16 Missing ⚠️
vortex-array/src/arrays/listview/tests/take.rs 0.00% 15 Missing ⚠️
...ortex-array/src/arrays/chunked/vtable/canonical.rs 56.25% 14 Missing ⚠️
vortex-array/src/arrow/array.rs 0.00% 10 Missing ⚠️
vortex-array/src/vtable/validity.rs 71.42% 8 Missing ⚠️
...rtex-array/src/arrays/constant/vtable/canonical.rs 94.59% 6 Missing ⚠️
...tex-array/src/arrays/scalar_fn/vtable/canonical.rs 0.00% 4 Missing ⚠️
vortex-array/src/compute/compare.rs 78.94% 4 Missing ⚠️
... and 46 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

joseph-isaacs and others added 2 commits December 1, 2025 12:29
- Use vortex_expect in benchmarks for append_to_builder and to_canonical
- Convert simple tests to return VortexResult<()> where appropriate
- Add VortexExpect/VortexResult imports where needed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants