Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Polar Signals Profiling ResultsLatest Run
Previous Runs (1)
Powered by Polar Signals Cloud |
Merging this PR will not alter performance
Comparing Footnotes
|
Benchmarks: TPC-H SF=1 on S3Summary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (1.161x ➖, 0↑ 4↓)
datafusion / vortex-compact (1.083x ➖, 0↑ 4↓)
datafusion / parquet (1.015x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (1.073x ➖, 0↑ 2↓)
duckdb / vortex-compact (0.979x ➖, 0↑ 0↓)
duckdb / parquet (0.991x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: TPC-H SF=1 on NVMESummary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (1.071x ➖, 0↑ 7↓)
datafusion / vortex-compact (1.050x ➖, 0↑ 5↓)
datafusion / parquet (1.003x ➖, 2↑ 3↓)
datafusion / arrow (0.986x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (0.998x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.999x ➖, 0↑ 0↓)
duckdb / parquet (0.983x ➖, 4↑ 1↓)
duckdb / duckdb (1.007x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: FineWeb NVMeSummary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (0.995x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.976x ➖, 0↑ 0↓)
datafusion / parquet (0.934x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.080x ➖, 0↑ 4↓)
duckdb / vortex-compact (0.960x ➖, 2↑ 0↓)
duckdb / parquet (0.990x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: TPC-DS SF=1 on NVMESummary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (1.017x ➖, 0↑ 1↓)
datafusion / vortex-compact (0.885x ✅, 73↑ 0↓)
datafusion / parquet (1.028x ➖, 0↑ 4↓)
duckdb / vortex-file-compressed (0.918x ➖, 37↑ 0↓)
duckdb / vortex-compact (0.935x ➖, 15↑ 0↓)
duckdb / parquet (0.912x ➖, 40↑ 0↓)
duckdb / duckdb (0.934x ➖, 24↑ 0↓)
Full attributed analysis
|
Benchmarks: PolarSignals ProfilingSummary
datafusion / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
|
Benchmarks: TPC-H SF=10 on NVMESummary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (0.899x ✅, 12↑ 0↓)
datafusion / vortex-compact (0.914x ➖, 5↑ 0↓)
datafusion / parquet (0.927x ➖, 4↑ 0↓)
datafusion / arrow (0.878x ✅, 16↑ 0↓)
duckdb / vortex-file-compressed (0.917x ➖, 5↑ 0↓)
duckdb / vortex-compact (0.932x ➖, 3↑ 0↓)
duckdb / parquet (0.965x ➖, 0↑ 0↓)
duckdb / duckdb (0.960x ➖, 1↑ 0↓)
Full attributed analysis
|
Benchmarks: FineWeb S3Summary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (1.035x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.088x ➖, 0↑ 1↓)
datafusion / parquet (1.134x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.050x ➖, 0↑ 1↓)
duckdb / vortex-compact (1.047x ➖, 0↑ 0↓)
duckdb / parquet (1.058x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: TPC-H SF=10 on S3Summary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (0.980x ➖, 0↑ 0↓)
datafusion / vortex-compact (1.088x ➖, 1↑ 2↓)
datafusion / parquet (0.967x ➖, 2↑ 0↓)
duckdb / vortex-file-compressed (1.034x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.005x ➖, 0↑ 0↓)
duckdb / parquet (1.013x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: Clickbench on NVMESummary
VerdictNo clear signal
Statistical Summary
datafusion / vortex-file-compressed (1.103x ❌, 0↑ 17↓)
datafusion / parquet (1.065x ➖, 0↑ 12↓)
duckdb / vortex-file-compressed (0.990x ➖, 6↑ 1↓)
duckdb / parquet (0.994x ➖, 0↑ 0↓)
duckdb / duckdb (1.027x ➖, 0↑ 1↓)
Full attributed analysis
|
Benchmarks: Statistical and Population GeneticsSummary
VerdictNo clear signal
Statistical Summary
duckdb / vortex-file-compressed (0.994x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.042x ➖, 0↑ 1↓)
duckdb / parquet (1.016x ➖, 0↑ 0↓)
Full attributed analysis
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Benchmarks: Random AccessSummary
unknown / unknown (0.899x ✅, 10↑ 0↓)
|
Benchmarks: CompressionSummary
unknown / unknown (1.008x ➖, 0↑ 7↓)
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # Cargo.lock
| /// - `T` for text/string types | ||
| /// - `B` for boolean | ||
| /// - `P` for timestamp/date types | ||
| pub fn slt_type_char(&self) -> char { |
There was a problem hiding this comment.
I think this is at least somewhat handled in the SLT crate itself
| /// `sqllogictest::default_validator` with `datafusion_sqllogictest::value_normalizer`. | ||
| /// | ||
| /// Returns `Ok(())` if the results match, or `Err` with a diff description. | ||
| pub fn validate_against_slt( |
There was a problem hiding this comment.
Why do we need to do this on our own?
|
I only realized what you're trying to do here over the weekend, WDYT about folding it into |
Summary
Closes: #000
Testing