chore: AggregateFnRef [de]serialize#7070
Merged
Conversation
Signed-off-by: blaginin <github@blaginin.me>
blaginin
changed the title
AggregateFnRef [de]serializeAggregateFnRef [de]serialize
Signed-off-by: blaginin <github@blaginin.me>
gatesn
reviewed
Mar 19, 2026
| /// Serialize this aggregate function's options to bytes. | ||
| /// | ||
| /// Returns `Ok(None)` if the function is not serializable. | ||
| pub fn serialize(&self) -> VortexResult<Option<Vec<u8>>> { |
Contributor
There was a problem hiding this comment.
I think this should instead be self.options().serialize() and not have this function at all
Member
Author
There was a problem hiding this comment.
maybe df97bac so it'll be similar to expr experience?
gatesn
reviewed
Mar 19, 2026
| /// | ||
| /// Looks up the aggregate function plugin by ID in the session's registry | ||
| /// and delegates deserialization to it. | ||
| pub fn deserialize(id: &str, metadata: &[u8], session: &VortexSession) -> VortexResult<Self> { |
Contributor
There was a problem hiding this comment.
I don't know whether this should live here, or AggregateSession::deserialize(&self, id: &AggregateFnId, metadata: &[u8])
Signed-off-by: blaginin <github@blaginin.me>
Co-authored-by: Nicholas Gates <nick@nickgates.com> Signed-off-by: blaginin <github@blaginin.me>
gatesn
reviewed
Mar 19, 2026
Merging this PR will improve performance by 10.34%
Performance Changes
Comparing 
Footnotes
|
Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: blaginin <github@blaginin.me>
Signed-off-by: blaginin <github@blaginin.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.