Merged
Conversation
There was a problem hiding this comment.
3 issues found across 5 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="src/claude_notes/cli.py">
<violation number="1" location="src/claude_notes/cli.py:28">
Decoding Windows project names replaces every '-' with a backslash, so encoded folders coming from paths like C:\Projects\my-project decode to C:\Projects\my\project, corrupting any directory name that contains a hyphen. Please add an escaping scheme (e.g., distinguish real hyphens from separators) so Windows paths round-trip correctly.</violation>
</file>
<file name="src/claude_notes/pager.py">
<violation number="1" location="src/claude_notes/pager.py:220">
Using `ch.lower()` here causes uppercase `G` to route to the top handler, preventing the capital key from reaching the bottom branch below. Limit this condition to the lowercase key only.</violation>
<violation number="2" location="src/claude_notes/pager.py:261">
`ch.lower()` can never equal the uppercase string "G", so this branch is unreachable and Unix users cannot jump to the bottom. Compare directly against "G" instead.</violation>
</file>
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Ask questions if you need clarification on any suggestion
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
Owner
|
@jackoelv thank you for the PR. |
1. encode folders name "-" to "--", when decode, "--" to "-". 2. get rid of all .lower() func.
Contributor
Author
|
I have fix the issues and submit changes. But I have not test on my windows, because I'm working on Mac. please review it once more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanks for your project. I try to fix some bugs in windows, now It`s working fine, we can create a win branch for windows. thanks.
Summary by cubic
Improved Windows support across the CLI and pager: fixed console encoding, path encoding/decoding, and interactive input on Windows. Windows users can now list/open projects and page through output reliably.
Bug Fixes
Dependencies
Written for commit d83d968. Summary will update automatically on new commits.