Skip to content

feat: Support non-ID query selector #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: next
Choose a base branch
from
Draft

feat: Support non-ID query selector #20

wants to merge 3 commits into from

Conversation

@shwilliam
Copy link
Collaborator

These changes enable support for using <vue-skip-to> to target elements with non-ID selectors. If the to prop passed does not start with a '#', a button will be rendered with a click-handler that will focus the first DOM element that matches the selector.

Before merging, this would need work on:

  • handling compound selectors that start with an ID (eg. '#main.first-paragraph')
  • styling the skip-link button

@shwilliam shwilliam requested a review from ktquez June 19, 2020 21:56
ktquez
ktquez approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@ktquez ktquez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktquez ktquez ktquez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shwilliam @ktquez