-
-
Notifications
You must be signed in to change notification settings - Fork 9k
fix(runtime-vapor): Loss of css var in Teleport #14284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
fix(runtime-vapor): Loss of css var in Teleport #14284
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/compiler-ssr
@vue/compiler-vapor
@vue/reactivity
@vue/runtime-core
@vue/runtime-dom
@vue/runtime-vapor
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
|
the vdom mode has the same problem. I'm trying to fix it! |
|
Thanks for the PR! |
| ;(nodes.onUpdated || (nodes.onUpdated = [])).push(() => | ||
| updateCssVars(this), | ||
| ) | ||
| } else if (isVaporComponent(nodes) && isFragment(nodes.block)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should consider recursively processing child nodes
see repl with this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll revise it!
e60b9a9 to
623bfb2
Compare
623bfb2 to
f0f4246
Compare
Playground