Skip to content

Conversation

@jackma9604
Copy link

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Size Report

Bundles

File Size Gzip Brotli
compiler-dom.global.prod.js 85.5 kB 30 kB 26.5 kB
runtime-dom.global.prod.js 108 kB 40.7 kB 36.6 kB
vue.global.prod.js 167 kB 60.8 kB 54 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.3 kB 18.9 kB 17.3 kB
createApp 57.3 kB 22 kB 20.1 kB
createApp + vaporInteropPlugin 85.4 kB 31.9 kB 28.8 kB
createVaporApp 27.6 kB 10.6 kB 9.72 kB
createSSRApp 61.6 kB 23.9 kB 21.7 kB
defineCustomElement 63.3 kB 23.9 kB 21.8 kB
overall 72.1 kB 27.3 kB 24.9 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 6, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14284
npm i https://pkg.pr.new/@vue/compiler-core@14284
yarn add https://pkg.pr.new/@vue/compiler-core@14284.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14284
npm i https://pkg.pr.new/@vue/compiler-dom@14284
yarn add https://pkg.pr.new/@vue/compiler-dom@14284.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14284
npm i https://pkg.pr.new/@vue/compiler-sfc@14284
yarn add https://pkg.pr.new/@vue/compiler-sfc@14284.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14284
npm i https://pkg.pr.new/@vue/compiler-ssr@14284
yarn add https://pkg.pr.new/@vue/compiler-ssr@14284.tgz

@vue/compiler-vapor

pnpm add https://pkg.pr.new/@vue/compiler-vapor@14284
npm i https://pkg.pr.new/@vue/compiler-vapor@14284
yarn add https://pkg.pr.new/@vue/compiler-vapor@14284.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14284
npm i https://pkg.pr.new/@vue/reactivity@14284
yarn add https://pkg.pr.new/@vue/reactivity@14284.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14284
npm i https://pkg.pr.new/@vue/runtime-core@14284
yarn add https://pkg.pr.new/@vue/runtime-core@14284.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14284
npm i https://pkg.pr.new/@vue/runtime-dom@14284
yarn add https://pkg.pr.new/@vue/runtime-dom@14284.tgz

@vue/runtime-vapor

pnpm add https://pkg.pr.new/@vue/runtime-vapor@14284
npm i https://pkg.pr.new/@vue/runtime-vapor@14284
yarn add https://pkg.pr.new/@vue/runtime-vapor@14284.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14284
npm i https://pkg.pr.new/@vue/server-renderer@14284
yarn add https://pkg.pr.new/@vue/server-renderer@14284.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14284
npm i https://pkg.pr.new/@vue/shared@14284
yarn add https://pkg.pr.new/@vue/shared@14284.tgz

vue

pnpm add https://pkg.pr.new/vue@14284
npm i https://pkg.pr.new/vue@14284
yarn add https://pkg.pr.new/vue@14284.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14284
npm i https://pkg.pr.new/@vue/compat@14284
yarn add https://pkg.pr.new/@vue/compat@14284.tgz

commit: f0ee98d

@jackma9604
Copy link
Author

the vdom mode has the same problem. I'm trying to fix it!

@edison1105 edison1105 added need test The PR has missing test cases. 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. scope: vapor related to vapor mode labels Jan 7, 2026
@edison1105
Copy link
Member

Thanks for the PR!
Could you please add a test case?

;(nodes.onUpdated || (nodes.onUpdated = [])).push(() =>
updateCssVars(this),
)
} else if (isVaporComponent(nodes) && isFragment(nodes.block)) {
Copy link
Member

@edison1105 edison1105 Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should consider recursively processing child nodes
see repl with this PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I'll revise it!

@jackma9604 jackma9604 force-pushed the fix/loss-of-css-var-in-teleport branch from e60b9a9 to 623bfb2 Compare January 7, 2026 12:56
@jackma9604 jackma9604 requested a review from edison1105 January 7, 2026 13:00
@jackma9604 jackma9604 force-pushed the fix/loss-of-css-var-in-teleport branch from 623bfb2 to f0f4246 Compare January 7, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. need test The PR has missing test cases. scope: vapor related to vapor mode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants