Skip to content

Conversation

@rzzf
Copy link
Contributor

@rzzf rzzf commented Jan 6, 2026

resolves #14254

Summary by CodeRabbit

Release Notes

  • New Features
    • Added Popover API support, enabling configuration of popover display modes and target actions for enhanced UI control

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

Adds three new optional properties to the HTMLAttributes interface for Popover API support: popover, popoverTargetAction, and popoverTarget. These are TypeScript type declarations only with no logic or control flow changes.

Changes

Cohort / File(s) Summary
Type Declaration Updates
packages/runtime-dom/src/jsx.ts
Added three optional properties to HTMLAttributes: popover (accepts '', 'auto', 'manual', 'hint'), popoverTargetAction (accepts 'toggle', 'show', 'hide'), and popoverTarget (accepts string). Extends Popover API support in type definitions.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops with glee and cheer,
Popovers now appear so clear,
Three tiny props, so neat and bright,
Type-safe HTML, a fuzzy delight! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'types(jsx): add Popover API' clearly and concisely describes the main change: adding Popover API type definitions to the JSX module. It is specific, directly related to the changeset, and follows conventional commit message format.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aac7e18 and 7aec826.

📒 Files selected for processing (1)
  • packages/runtime-dom/src/jsx.ts
🔇 Additional comments (1)
packages/runtime-dom/src/jsx.ts (1)

343-346: LGTM! Popover API types are spec-compliant.

The Popover API properties are correctly defined and align with the HTML Standard. The 'hint' value is valid (though experimental with limited browser support), along with 'auto' and 'manual'. The popoverTargetAction values ('toggle', 'show', 'hide') and popoverTarget string type are all correct. Attribute names follow Vue's camelCase JSX conventions appropriately.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 103 kB 39.1 kB 35.2 kB
vue.global.prod.js 161 kB 59.1 kB 52.6 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 47 kB 18.4 kB 16.8 kB
createApp 55.2 kB 21.4 kB 19.6 kB
createSSRApp 59.4 kB 23.2 kB 21.1 kB
defineCustomElement 60.7 kB 23.1 kB 21.1 kB
overall 69.5 kB 26.7 kB 24.3 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 6, 2026

Open in StackBlitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@14286
npm i https://pkg.pr.new/@vue/compiler-core@14286
yarn add https://pkg.pr.new/@vue/compiler-core@14286.tgz

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@14286
npm i https://pkg.pr.new/@vue/compiler-dom@14286
yarn add https://pkg.pr.new/@vue/compiler-dom@14286.tgz

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@14286
npm i https://pkg.pr.new/@vue/compiler-sfc@14286
yarn add https://pkg.pr.new/@vue/compiler-sfc@14286.tgz

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@14286
npm i https://pkg.pr.new/@vue/compiler-ssr@14286
yarn add https://pkg.pr.new/@vue/compiler-ssr@14286.tgz

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@14286
npm i https://pkg.pr.new/@vue/reactivity@14286
yarn add https://pkg.pr.new/@vue/reactivity@14286.tgz

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@14286
npm i https://pkg.pr.new/@vue/runtime-core@14286
yarn add https://pkg.pr.new/@vue/runtime-core@14286.tgz

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@14286
npm i https://pkg.pr.new/@vue/runtime-dom@14286
yarn add https://pkg.pr.new/@vue/runtime-dom@14286.tgz

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@14286
npm i https://pkg.pr.new/@vue/server-renderer@14286
yarn add https://pkg.pr.new/@vue/server-renderer@14286.tgz

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@14286
npm i https://pkg.pr.new/@vue/shared@14286
yarn add https://pkg.pr.new/@vue/shared@14286.tgz

vue

pnpm add https://pkg.pr.new/vue@14286
npm i https://pkg.pr.new/vue@14286
yarn add https://pkg.pr.new/vue@14286.tgz

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@14286
npm i https://pkg.pr.new/@vue/compat@14286
yarn add https://pkg.pr.new/@vue/compat@14286.tgz

commit: 7aec826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant