Skip to content

T7929: VPP: nat44: validate that only self-twice-nat external address is in translation pool #4805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

T7929: VPP: nat44: validate that only self-twice-nat external address is in translation pool #4805

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/conf_mode/vpp_nat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,6 @@ def verify(config):
f'{error_msg} external address/port is already in use!'
)
addresses_with_ports.add(pair)
if ext_address not in addresses_translation:
raise ConfigError(
f'{error_msg} external address {ext_address} is not in "address-pool translation"'
)

else:
if ext_address in addresses_without_ports or any(
Expand All @@ -300,6 +296,13 @@ def verify(config):
local_addresses.add(local_address)

options = rule_config.get('options', {})

if 'self_twice_nat' in options and ext_address not in addresses_translation:
raise ConfigError(
f'{error_msg} external address {ext_address} must be part of '
'"address-pool translation" when using self-twice-nat'
)

if all(key in options for key in ('twice_nat', 'self_twice_nat')):
raise ConfigError(
f'{error_msg} cannot set both options "twice-nat" and "self-twice-nat"'
Expand Down
Loading