-
Notifications
You must be signed in to change notification settings - Fork 70
T6823: correctly set the IPv6 autoconf option #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eceeb15 to
f9b87ea
Compare
gaige
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change for readability and a question about where we want to test this in integration.
tests/integration/targets/vyos_l3_interfaces/tests/cli/_remove_config.yaml
Outdated
Show resolved
Hide resolved
tests/integration/targets/vyos_l3_interfaces/tests/cli/gathered.yaml
Outdated
Show resolved
Hide resolved
|
All contributors have signed the CLA ✍️ ✅ |
f4097f5 to
23c9a35
Compare
gaige
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 more changes
dmbaturin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code doesn't look incorrect to me and I trust @gaige's judgement.
Change Summary
Types of changes
Related Task(s)
Related PR(s)
Component(s) name
Proposed changes
How to test
Test results
Tested against VyOS versions:
Checklist:
changelogs/fragmentsto describe the changes