Skip to content

Conversation

@nichtich
Copy link
Contributor

@nichtich nichtich commented Apr 7, 2019

This simplifies update to make sure the registry always contains the current table.

@nichtich nichtich requested a review from msporny as a code owner April 7, 2019 13:48
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the notion behind this PR... but if it breaks the live preview, we shouldn't do it.

<c>blake2s-248</c><c>0xb25f</c><c>active</c><c><xref target="RFC7693">RFC 7693</xref></c>
<c>blake2s-256</c><c>0xb260</c><c>active</c><c><xref target="RFC7693">RFC 7693</xref></c>
</texttable>
&registry;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, do you know if this change will break the browser-based rendering of the specification? Note that you can view a live version of the latest editor's draft here: https://w3c-dvcg.github.io/multihash/index.xml ... is this PR going to break that browser-based preview?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not aware of that but the preview is incomplete anyway because it does not include references. I could extend the .xsl file to fix this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please do, if possible. I'm not paying too much attention to the how... just that we want the browser-based rendering to continue to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants