Skip to content

Conversation

@daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Dec 19, 2025

πŸš€ Netlify Preview:
πŸ”„ this PR updates the following sspecs:

@pkra @spectranaut @jnurthen

this updates the Netlify preview experience by updating the first comment of the GitHub issue with the specs that are changed as well as the diff with respect to their EDs

I tried just randomly changing ARIA and Core-AAM for uss to see how this would look like.

I think this should be good to land if you all agree, but before we land we should make sure we restore the spec source files.


Preview | Diff

@netlify
Copy link

netlify bot commented Dec 19, 2025

βœ… Deploy Preview for wai-aria ready!

Name Link
πŸ”¨ Latest commit 29e54a4
πŸ” Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/69458a3af7a5d30008432b6f
😎 Deploy Preview https://deploy-preview-2703--wai-aria.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

πŸš€ Deployed on https://deploy-preview-2703--wai-aria.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 19, 2025 17:08 Inactive
@daniel-montalvo daniel-montalvo added editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo and removed spec:core-aam spec:aria spec:dpub-aria spec:pdf-aam labels Dec 19, 2025
@daniel-montalvo
Copy link
Contributor Author

daniel-montalvo commented Dec 19, 2025

Fixes #2242

The downside with this is that it wouldn't work on forks as it depends on secrets to run. Other alternatives we've tried are either too noisy (they duplicate comments) or they'd require for us to change the structure of the repo, having one root index.html as an Overview page and making the main ARIA spec its own subfolder, similarly to how the other child specs work.
That's the approach they've taking for WCAG deploy previews, but I remember some people strongly argued not to change our repo structure when we took on the monorepo project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

editorial a change to an example, note, spelling, grammar, or is related to publishing or the repo spec:accname spec:aria spec:core-aam spec:dpub-aria spec:pdf-aam

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants