-
Notifications
You must be signed in to change notification settings - Fork 141
Editorial: Improve netlify preview #2703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Try preview link updates
β¦review-comments
β Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
π Deployed on https://deploy-preview-2703--wai-aria.netlify.app |
|
Fixes #2242 The downside with this is that it wouldn't work on forks as it depends on secrets to run. Other alternatives we've tried are either too noisy (they duplicate comments) or they'd require for us to change the structure of the repo, having one root index.html as an Overview page and making the main ARIA spec its own subfolder, similarly to how the other child specs work. |
π Netlify Preview:
π this PR updates the following sspecs:
@pkra @spectranaut @jnurthen
this updates the Netlify preview experience by updating the first comment of the GitHub issue with the specs that are changed as well as the diff with respect to their EDs
I tried just randomly changing ARIA and Core-AAM for uss to see how this would look like.
I think this should be good to land if you all agree, but before we land we should make sure we restore the spec source files.
Preview | Diff