Skip to content

[RFC] Safety limits #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmcase wants to merge 41 commits into
base: main
Choose a base branch
from
+332 −74
Open

[RFC] Safety limits #309

Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
7a4c504
Update api.bs
bmcase Nov 12, 2025
3db4368
update safety limit draft
bmcase Nov 12, 2025
a8c6b8d
update safety limit draft
bmcase Nov 12, 2025
f217ef5
add user action checks
bmcase Dec 4, 2025
3339298
have budget and safety checks together
bmcase Dec 4, 2025
140ae91
safety limit and privacy deductions iff all can occur.
bmcase Dec 5, 2025
5527b8d
clean up
bmcase Dec 5, 2025
b4b0575
Merge branch 'main' into safety_limits
bmcase Feb 6, 2026
7dd5ecd
remove conversion site quota and store for user actions
bmcase Feb 6, 2026
c42e70c
deductions for impression sites
bmcase Feb 6, 2026
ec0f4c9
move safety configuration into implementation defined values
bmcase Feb 6, 2026
d0395ed
handle cases in compute impression site deductions
bmcase Feb 9, 2026
84fce81
pass parameters
bmcase Feb 9, 2026
55634d3
update function signature
bmcase Feb 9, 2026
61ff7e7
fix some bikeshed links
bmcase Feb 9, 2026
1721e6d
fix link
bmcase Feb 9, 2026
a95b7b1
update user activation checks on measure conversion
bmcase Feb 9, 2026
0997b83
clean up errors and user activation
bmcase Feb 9, 2026
737e81c
clean up warnings
bmcase Feb 9, 2026
956417d
address feedback
bmcase Feb 10, 2026
9e1149e
factor out budget checks
bmcase Feb 10, 2026
9970c90
address PR feedback
bmcase Feb 10, 2026
3a0f73c
fix bikeshed warnings
bmcase Feb 10, 2026
cc0f86a
incorporate feedback
bmcase Feb 10, 2026
51f2d25
change `check attribution API activation` to throw
bmcase Feb 12, 2026
2892064
address Andrew's feedback on PR
bmcase Feb 12, 2026
2ca92de
fix checks
bmcase Feb 12, 2026
7b1cf1a
description of user activation for the API
bmcase Feb 13, 2026
36b54e8
remove impressionsBySite map
bmcase Feb 13, 2026
f2daa48
address PR feedback
bmcase Feb 13, 2026
d164cf7
fix link
bmcase Feb 13, 2026
f740ef9
fix errors
bmcase Feb 13, 2026
580473a
use set of impressionSites
bmcase Feb 13, 2026
8ad8c97
remove map of impression site deductions
bmcase Feb 19, 2026
3af4cf4
fix checks and links
bmcase Feb 19, 2026
d18e5eb
fix check
bmcase Feb 19, 2026
a4d2d2c
address feedback
bmcase Feb 20, 2026
699b2f3
refactor for epoch cadences
bmcase Feb 26, 2026
f0242f9
fix checks
bmcase Feb 27, 2026
711496b
safety limit epoch start
bmcase Feb 27, 2026
bd6bb43
fix checks
bmcase Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading