Conversation
aphillips
left a comment
aphillips
left a comment
There was a problem hiding this comment.
This is a great start! Thank you for taking this on.
|
So far so good. I guess you know that you'll need to add the bidi_user_interface label for the related review comments link to work. |
✅ Deploy Preview for bp-i18n-specdev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aphillips
left a comment
aphillips
left a comment
There was a problem hiding this comment.
Still a good start, but this should be written more generically. This treats RTL as an aberration.
|
|
||
|
|
||
| <section id="typ_bidi_styling" class="subtopic"> | ||
| <h3>Bidi styling</h3> |
There was a problem hiding this comment.
I'm not sure I'd call this "styling", since that evokes CSS more than might be appropriate. The items here are about layout and presentation. Not sure I'd call it "bidi" either.
I think this is more important (common) than vertical text. I'd move this section above that one and suggest calling it Presentation and Layout or possibly Item and Block Progression (this leaves room for future progression-related items).
@r12a's objection to that will be that people won't find it easily in the document, especially if they are looking for keywords like "bidi" or "RTL" 😺
There was a problem hiding this comment.
I think you have a point, but I don't want to make this subsection too long unless we divide it into several smaller subsubsections.
There was a problem hiding this comment.
That's not my point? I'm saying that the section title is wrong. Also, note that what is currently in the section can grow over time, as we find other best practices to include. The length of a subsection depends on what material and BPs are needed.
There was a problem hiding this comment.
Sorry, I mistook "move" for "merge". I'm neutral on this suggestion. I can accept the section title being changed or not. If no one else objects, I'll change the section title.
…g' into xfq/layout-mirroring
Co-authored-by: Addison Phillips <addisonI18N@gmail.com>
3 participants
Preview | Diff