Issue #486 ValidationReport UML #487
Conversation
VladimirAlexiev
requested review from
HolgerKnublauch,
YoucTagh,
bergos and
jeswr
Co-authored-by: Yousouf Taghzouti <48333491+YoucTagh@users.noreply.github.com>
shacl12-core/index.html
Outdated
| // Load and inline SVG diagrams | ||
| // TODO: add <svg desc> for accessibility | ||
| function svgInline(svg) { | ||
| fetch('images/'+svg) | ||
| .then(response => response.text()) | ||
| .then(svgText => { | ||
| const container = document.getElementById(svg); | ||
| container.innerHTML = svgText; | ||
| })}; | ||
|
|
||
| // svgInline('SHACL-UML.svg'); | ||
| svgInline('ValidationReport-UML.svg'); |
There was a problem hiding this comment.
Why don't you use plain HTML with an img element? That would reduce the total lines of JS code and make the spec a bit easier to maintain.
There was a problem hiding this comment.
I think we won't have clickable links with img.
There was a problem hiding this comment.
Makes sense. But it should be mentioned in the comment.
There was a problem hiding this comment.
@bergos that's exactly the reason.
Same as this prior PR: replace with script that embeds SVG content
Co-authored-by: Thomas Bergwinkl <bergos@users.noreply.github.com>
Co-authored-by: Yousouf Taghzouti <48333491+YoucTagh@users.noreply.github.com>
|
@YoucTagh adding the abstract class results in 2 parallel arrows (one relation, the other inheritance). Do you really like this? 
|
|
@VladimirAlexiev, I believe this better reflects the model. However, I think it would be clearer if the two arrows were not positioned directly on top of each other. |
|
@VladimirAlexiev, could you please update the PR to reflect this suggestion:
|
|
hi @YoucTagh , does this look ok? |
|
@bergos the comment now says // Load and inline SVG diagrams for clickable links |
|
@VladimirAlexiev, could you please resolve the conflict by pulling the current @bergos, do you approve the changes? |
4 participants
Closes #486
See document rendered online. UPD: works now.
Note: For some reason the HTML preview doesn't work right now (githack cache is not invalidated?). These two show different things (Do I have some stupid mistake in the URLs?):
You can see the diagram in "Files changed"