Skip to content

Conversation

@streude
Copy link
Contributor

@streude streude commented Oct 10, 2025

  • started writing script to generate test data
  • create script to subset "master" TTF file for pass/fail test results
  • copied/updated demo client code to use on demo pages and dynamically assign fonts based on conformance test name

@garretrieger
Copy link
Contributor

Finished up reviewing. I was able to easily run the script and generate the test html, so can confirm this works without needing any special setup.

So just a couple more high level things:

  • Can you update the README with instructions on how to use the test and font generation scripts.
  • The base IFT font (which the individual tests derive from) is checked in, but there doesn't seem to be anything to help recreate/update it. It would be good to have this setup so that the base IFT font can be easily rebuilt. Something like the setup in ift-demo. I'm fine with doing that as a separate PR to keep this one from getting too complicated.

@streude
Copy link
Contributor Author

streude commented Oct 31, 2025

Finished up reviewing. I was able to easily run the script and generate the test html, so can confirm this works without needing any special setup.

So just a couple more high level things:

  • Can you update the README with instructions on how to use the test and font generation scripts.
  • The base IFT font (which the individual tests derive from) is checked in, but there doesn't seem to be anything to help recreate/update it. It would be good to have this setup so that the base IFT font can be easily rebuilt. Something like the setup in ift-demo. I'm fine with doing that as a separate PR to keep this one from getting too complicated.

Hey @garretrieger , I think I've addressed all of the issues except the IFT source generation. I think it'd be best to save that for a separate PR. Let me know what you think.

@streude streude requested a review from garretrieger October 31, 2025 14:50
Copy link
Contributor

@garretrieger garretrieger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, this looks good to me now.

@garretrieger
Copy link
Contributor

Hey @garretrieger , I think I've addressed all of the issues except the IFT source generation. I think it'd be best to save that for a separate PR. Let me know what you think.

Works for me.

@garretrieger garretrieger merged commit 912a2e9 into main Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants