chore: export Installed Web Application Identity #1187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR exports the "identity" definition for installed web applications to make it referenceable from external specifications. The change updates the definition scope and all references throughout the document.
- Updates the definition scope from "identity" to "installed web application/identity" with export class
- Updates all references to use the new scoped definition format
- Fixes a reference list item to use the correct "id" instead of "identity"
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| <li>[=manifest/icons=] | ||
| </li> | ||
| <li>[=manifest/identity=] | ||
| <li>[=manifest/id=] |
There was a problem hiding this comment.
The reference should be [=manifest/identity=] to match the definition being discussed in this section, not [=manifest/id=]. The id is the member name, but the concept being referenced is the identity.
Suggested change
| <li>[=manifest/id=] | |
| <li>[=manifest/identity=] |
There was a problem hiding this comment.
You're wrong, co-pilot... this is about the manifest members, not the concepts (but I still love you).
github-actions bot
added a commit
that referenced
this pull request
Sep 3, 2025
SHA: 2d457e2 Reason: push, by marcoscaceres Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (choose at least one, delete ones that don't apply):
Need this for w3c/push-api#402
Preview | Diff