Skip to content

Handle not fully active documents when querying Permissions API #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
marcoscaceres wants to merge 5 commits into from
Closed

Handle not fully active documents when querying Permissions API #249

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a41a040
Handle not fully active documents when querying Permissions API
marcoscaceres Jun 29, 2021
487e1f9
remove update to denied... leave it alone
marcoscaceres Jun 29, 2021
89cb77b
Removed var that's not needed
marcoscaceres Jun 29, 2021
19ed04b
Add fully active check when event fires instead
marcoscaceres Jun 29, 2021
613b424
handling of fully active
marcoscaceres Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ spec:webidl; type:interface; text:Promise
A |descriptor|'s <dfn export local-lt="state">permission state</dfn> for
an optional <a>environment settings object</a> |settings| is
the result of the following algorithm, which returns one of
{{PermissionState/"granted"}}, {{PermissionState/"prompt"}}, or {{PermissionState/"denied"}}:
the {{PermissionState}} enum values or failure:
</p>
<ol class="algorithm">
<li>
Expand All @@ -213,6 +213,9 @@ spec:webidl; type:interface; text:Promise
<code>|descriptor|.{{PermissionDescriptor/name}}</code> and |settings| has an
<a>associated `Document`</a> named <var>document</var>, run the following step:
<ol class="algorithm">
<li>
If |document| is not [=Document/fully active=], return failure.
</li>
<li>
If <var>document</var> is not <a>allowed to use</a> the feature
identified by <code>|descriptor|.{{PermissionDescriptor/name}}</code>
Expand Down Expand Up @@ -464,6 +467,12 @@ spec:webidl; type:interface; text:Promise
it MUST asynchronously run the following steps:
</p>
<ol>
<li>
Let |document| this |status|'s [=relevant global object=]'s [=associated Document=].
<li>
<li>
If |document| is null or |document| is not [=Document/fully active=], terminate this algorithm.
</li>
<li>
Run <code><var>status</var>@{{PermissionStatus/[[query]]}}.{{PermissionDescriptor/name}}</code>'s <a>permission
query algorithm</a>, passing <code><var>status</var>@{{PermissionStatus/[[query]]}}</code>
Expand Down Expand Up @@ -512,6 +521,15 @@ spec:webidl; type:interface; text:Promise
<var>permissionDesc</var>:
</p>
<ol>
<li>
If [=this=] [=relevant global object=] is a {{Window}} object, then:
<ol>
<li>If the [=current settings object's=] <a>associated `Document`</a> is not
[=Document/fully active=], return [=a promise rejected with=] a
{{"InvalidStateError"}} {{DOMException}}.
</li>
</ol>
</li>
<li>Let |rootDesc| be the object |permissionDesc| refers to, <a>converted to
an IDL value</a> of type {{PermissionDescriptor}}. If this throws an
exception, return <a>a promise rejected with</a> that exception and abort
Expand Down