Improve Android and SDK Compatibility Without Over-Upgrading #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates various dependencies and configurations across the project.
- Updates pubspec.lock and example/pubspec.lock with new dependency versions and hash values.
- Modifies example/android/app/build.gradle:
- Updates ndkVersion.
- Sets namespace.
- Changes sourceCompatibility and targetCompatibility to JavaVersion.VERSION_11.
- Adds kotlinOptions with jvmTarget = '11'.
- Updates SDK constraints in example/pubspec.yaml and pubspec.yaml.
- Updates flutter_lints version in example/pubspec.yaml and pubspec.yaml.
- Modifies example/android/gradle.properties by removing some Android properties.
- Updates android/build.gradle:
- Changes ext.kotlin_version.
- Updates compileSdkVersion.
- Changes sourceCompatibility and targetCompatibility to JavaVersion.VERSION_11.
- Adds kotlinOptions with jvmTarget = '11'.
- Sets namespace.
…cies and configurations
|
@w3connext , I really think this PR is a must for this package. Please, could you take a moment to review it? |
|
@w3connext , please take a look 🙏 |
Collaborator
|
Sorry for the late review, and thank you for your pull request. |
# Conflicts: # .gitignore # android/build.gradle # android/gradle/wrapper/gradle-wrapper.jar # android/gradle/wrapper/gradle-wrapper.properties # android/gradlew # android/gradlew.bat # android/settings.gradle # example/android/app/build.gradle # example/android/build.gradle # example/android/gradle/wrapper/gradle-wrapper.properties # example/android/settings.gradle # example/pubspec.lock # example/pubspec.yaml # pubspec.lock # pubspec.yaml
Contributor
Author
|
I have resolved conflicts with the latest changes @prongbang. This can be merged 🚀 |
Collaborator
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes a more conservative and compatibility-focused update to the Android build system and SDK versions.
There is already an open pull request (#24) that introduces improvements to the Android setup. However, that PR upgrades multiple components—Dart, Gradle, Kotlin, JVM, and compile SDK—to their latest available versions. While this may seem beneficial, it significantly reduces compatibility with existing applications and environments, making the package harder to integrate in real-world projects.
In my opinion, that approach is not ideal for a package intended to be widely usable. This PR takes a more balanced route: it modernizes the build system and dependencies, but chooses sensible version upgrades that maintain compatibility with older setups.
Key Differences
1.7.21to1.8.22(instead of jumping to2.x)33to34(not36)7.4to8.3(instead of8.4+)2.18to3.5, but constrained to>=3.5.0 <4.0.0to avoid locking out older appsThese changes aim to improve stability and compatibility without sacrificing support for existing projects. The goal is to ensure the package remains usable in a broader range of Flutter and Android environments.