Refactor WebSocket handshake error handling#1144
Open
joanhey wants to merge 4 commits intowalkor:masterfrom
Open
Refactor WebSocket handshake error handling#1144joanhey wants to merge 4 commits intowalkor:masterfrom
joanhey wants to merge 4 commits intowalkor:masterfrom
Conversation
Add error 426 if protocol is incorrect or 400 if don't exist.
Contributor
Author
|
We need to add the 2 tests and change other tests. |
Contributor
Author
|
Now is passing these tests, that never will pass with this change: https://github.com/walkor/workerman/blob/master/tests/Unit/Protocols/WsTest.php#L138-L141 https://github.com/walkor/workerman/blob/master/tests/Unit/Protocols/WsTest.php#L158-L161 https://github.com/walkor/workerman/blob/master/tests/Unit/Protocols/WsTest.php#L179-L180 https://github.com/walkor/workerman/blob/master/tests/Unit/Protocols/WsTest.php#L215-L217 We need to improve these tests. As only check that send a 400, is the same which header is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add error 426 if websocket version is incorrect or 400 if don't exist (RFC 6455 Section 4.4 and section-4.2.2 ).
Do you want than we create a test ? Because we have the test of Http11probe.