Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
📝 WalkthroughWalkthroughThis PR removes the Faucet component and all associated CI/release tooling, build artifacts, server code, UI assets, tests, metrics, configuration, documentation references, and prunes related dependencies from go.mod. Changes
Sequence Diagram(s)(omitted — this change removes an entire component and its flows rather than introducing a new or modified control flow worth diagramming) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labelsprotocol Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
protocol-developer-docs/3-installation.md (1)
61-61: Add an explicit note that Faucet moved to a separate repo.Readers expecting Faucet in compose/install may be confused. Add a short pointer to the new repo and that it’s no longer bundled.
Suggested insertion after the Docker section or at the end:
## Faucet The Faucet has been extracted to a separate repository and is no longer bundled with this repo. See: https://github.com/warden-protocol/faucetMakefile (1)
9-9: Makefile: build-faucet removed; add no-op all/clean/test stubs to silence checkmake.Confirmed: 'faucet' appears elsewhere in the repo but not in the Makefile .PHONY. Static analysis flags missing all/clean/test — add minimal no-op targets that route to help.
help: @echo "This project uses 'just' (https://github.com/casey/just) instead of 'make'." @echo "Refer to the full installation instructions at https://just.systems/man/en/chapter_4.html to install 'just'." @echo " Mac OS: brew install just" @echo " Arch Linux: pacman -S just" .PHONY: build-all build install build-wardend install-wardend build-wardenkms help +all clean test: + @$(MAKE) help
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
cmd/faucet/assets/background.svgis excluded by!**/*.svgcmd/faucet/images/favicon.icois excluded by!**/*.icogo.sumis excluded by!**/*.sum
📒 Files selected for processing (21)
.github/workflows/faucet.yml(0 hunks)Makefile(1 hunks)cmd/faucet/Dockerfile(0 hunks)cmd/faucet/css/style.css(0 hunks)cmd/faucet/faucet.go(0 hunks)cmd/faucet/faucet_test.go(0 hunks)cmd/faucet/js/circle.js(0 hunks)cmd/faucet/js/tx.js(0 hunks)cmd/faucet/main.go(0 hunks)cmd/faucet/metrics.go(0 hunks)cmd/faucet/pkg/config/config.go(0 hunks)cmd/faucet/templates/form.html(0 hunks)cmd/faucet/templates/index.html(0 hunks)cmd/faucet/templates/red-cross.html(0 hunks)cmd/faucet/templates/spinner.html(0 hunks)cmd/faucet/templates/tokens.html(0 hunks)cmd/faucet/templates/tx-result.html(0 hunks)cmd/faucet/templates/tx-status.html(0 hunks)go.mod(1 hunks)justfile(0 hunks)protocol-developer-docs/3-installation.md(1 hunks)
💤 Files with no reviewable changes (18)
- cmd/faucet/js/circle.js
- cmd/faucet/templates/spinner.html
- cmd/faucet/templates/form.html
- cmd/faucet/templates/red-cross.html
- .github/workflows/faucet.yml
- justfile
- cmd/faucet/templates/tokens.html
- cmd/faucet/templates/tx-status.html
- cmd/faucet/Dockerfile
- cmd/faucet/js/tx.js
- cmd/faucet/faucet_test.go
- cmd/faucet/templates/index.html
- cmd/faucet/metrics.go
- cmd/faucet/main.go
- cmd/faucet/css/style.css
- cmd/faucet/pkg/config/config.go
- cmd/faucet/faucet.go
- cmd/faucet/templates/tx-result.html
🧰 Additional context used
📓 Path-based instructions (1)
**/*.md
⚙️ CodeRabbit configuration file
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Files:
protocol-developer-docs/3-installation.md
🪛 checkmake (0.2.2)
Makefile
[warning] 9-9: Missing required phony target "all"
(minphony)
[warning] 9-9: Missing required phony target "clean"
(minphony)
[warning] 9-9: Missing required phony target "test"
(minphony)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: test
🔇 Additional comments (2)
go.mod (2)
331-331: Keep github.com/rs/zerolog (indirect) — it's still required transitively.
go mod why shows: github.com/warden-protocol/wardenprotocol/cmd/wardend -> github.com/cosmos/cosmos-sdk/server/cmd -> github.com/rs/zerolog; leave the indirect entry in go.mod.
323-323: Verify Prometheus client is still needed as indirect.go mod tidy in the sandbox failed due to unresolved internal module versions (github.com/warden-protocol/...), so I couldn't confirm whether github.com/prometheus/client_golang v1.23.2 // indirect is unused. Run locally and report results:
- go mod tidy -v
- go mod why -m github.com/prometheus/client_golang
- go list -deps ./... | rg 'github.com/prometheus' || true
- rg -nP 'prometheus/(client_golang|common|procfs)' -S
If those show no usage, run go mod tidy and commit the resulting go.mod/go.sum changes.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
wardend.just (1)
21-26: Optional: guard against invalid binary names in just targets.Fail fast if someone passes a non-existent binary (prevents confusing errors).
Apply this diff:
build binary="wardend": - go build \ + # Validate binary path exists + test -d ./cmd/{{ binary }} || { echo "Unknown binary '{{ binary }}' (missing ./cmd/{{ binary }})"; exit 1; } + go build \ {{ build_tags }} \ {{ ldflags }} \ -o {{ output_dir }}/{{ binary }} \ ./cmd/{{ binary }} install binary="wardend": - go install \ + # Validate binary path exists + test -d ./cmd/{{ binary }} || { echo "Unknown binary '{{ binary }}' (missing ./cmd/{{ binary }})"; exit 1; } + go install \ {{ build_tags }} \ {{ ldflags }} \ ./cmd/{{ binary }}
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/release-docker-images.yml(0 hunks).github/workflows/wardend.yaml(2 hunks)wardend.just(1 hunks)
💤 Files with no reviewable changes (1)
- .github/workflows/release-docker-images.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: lint
- GitHub Check: lint
- GitHub Check: Analyze (go)
🔇 Additional comments (3)
.github/workflows/wardend.yaml (2)
68-68: Reusable workflow secrets inheritance — LGTM.This aligns with calling ./.github/workflows/release-docker-images.yml.
25-25: ```shell
#!/bin/bash
set -euo pipefailecho "CWD: $(pwd)"
echo
f=".github/workflows/wardend.yaml"
if [[ -f "$f" ]]; then
echo "FOUND: $f"
echo "----- file start -----"
sed -n '1,240p' "$f" || true
echo "----- file end -----"
else
echo "$f not found"
fiecho
echo "--- Searching repo for go.sum and go.mod references ---"
rg --no-ignore -n -S --hidden 'go.sum' || echo "No go.sum mentions found."
rg --no-ignore -n -S --hidden 'go.mod' || echo "No go.mod mentions found."echo
echo "--- Searching for 'faucet' references ---"
rg --no-ignore -n -S -C1 --hidden -g '!/.git/' -g '!/vendor/' '\b(faucet|cmd/faucet)\b' || echo "No faucet references found."</blockquote></details> <details> <summary>wardend.just (1)</summary><blockquote> `13-19`: **Removed faucet from build target docs — LGTM.** Confirmed cmd/wardend, cmd/wardenkms, cmd/clichain exist. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
2 participants
I propose that we remove faucet code from wardenprotocol monorepo as the new version is now decoupled from the Wardend binary and migrated to different repository:
https://github.com/warden-protocol/faucet
The new version will be using the EVM endpoint instead of
wardendbinary.