Conversation
📝 WalkthroughWalkthroughRemoves App-level PreBlocker setup and method, updates upgrade handler key to v0.7.1, switches oracle config import from skip-mev/slinky to warden-protocol/connect, and drops the slinky dependency from go.mod. Adds an unreleased changelog entry for v0.7.1. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Node as Node
participant App as Warden App
participant Upgrader as Upgrade Router
rect rgb(240,245,250)
note over App: Old flow (before this change)
Node->>App: InitChain/Start
App->>App: SetPreBlocker(...)
App->>App: PreBlocker(ctx, reqFinalizeBlock)
end
rect rgb(245,240,245)
note over App: New flow (after this change)
Node->>App: InitChain/Start
App--xApp: No SetPreBlocker
App--xApp: PreBlocker method removed
end
rect rgb(240,250,245)
note over Upgrader: Upgrade key change
App->>Upgrader: SetUpgradeHandler("v0.7.1", handler)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (4)
CHANGELOG.md(1 hunks)cmd/wardend/config/wardend_config.go(1 hunks)go.mod(0 hunks)warden/app/app.go(1 hunks)
💤 Files with no reviewable changes (1)
- go.mod
🧰 Additional context used
📓 Path-based instructions (1)
**/*.md
⚙️ CodeRabbit configuration file
**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
Files:
CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
- GitHub Check: lint
- GitHub Check: test
- GitHub Check: test
- GitHub Check: lint
- GitHub Check: Analyze (go)
🔇 Additional comments (2)
warden/app/app.go (1)
879-881: LGTM! Upgrade handler correctly updated to v0.7.1.The upgrade handler key has been properly updated from "v0.7.0" to "v0.7.1", which aligns with the changelog entry and PR objectives. The migration logic correctly invokes
RunMigrationsto handle module version updates.cmd/wardend/config/wardend_config.go (1)
24-25: LGTM – import path verified. The new importgithub.com/warden-protocol/connect/oracle/configis present in go.mod at v1.3.0 and supplies the expectedoracleconfig.AppConfigtype.
This PR makes wardend actually use the wrapped preblocker from slinky so that prices are recorded onchain.
It also already prepares for a v0.7.1 network upgrade and release.
Closes ENG-712.