Skip to content

feat(oracle): enable slinky pre-blocker#1726

Merged
Pitasi merged 1 commit intomainfrom
enable-slinky-preblocker
Oct 9, 2025
Merged

feat(oracle): enable slinky pre-blocker#1726
Pitasi merged 1 commit intomainfrom
enable-slinky-preblocker

Conversation

@Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Oct 2, 2025

This PR makes wardend actually use the wrapped preblocker from slinky so that prices are recorded onchain.

It also already prepares for a v0.7.1 network upgrade and release.

Closes ENG-712.

@Pitasi Pitasi requested a review from a team as a code owner October 2, 2025 09:12
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 2, 2025

📝 Walkthrough

Walkthrough

Removes App-level PreBlocker setup and method, updates upgrade handler key to v0.7.1, switches oracle config import from skip-mev/slinky to warden-protocol/connect, and drops the slinky dependency from go.mod. Adds an unreleased changelog entry for v0.7.1.

Changes

Cohort / File(s) Summary
Changelog update
CHANGELOG.md
Added unreleased v0.7.1 entry noting a consensus-breaking change and release date.
Dependency and import migration
go.mod, cmd/wardend/config/wardend_config.go
Removed github.com/skip-mev/slinky from require; updated oracle config import path to github.com/warden-protocol/connect/oracle/config (alias unchanged).
App pre-blocker and upgrade handling
warden/app/app.go
Deleted SetPreBlocker invocation and removed App.PreBlocker method; updated upgrade handler key from "v0.7.0" to "v0.7.1".

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Node as Node
  participant App as Warden App
  participant Upgrader as Upgrade Router

  rect rgb(240,245,250)
  note over App: Old flow (before this change)
  Node->>App: InitChain/Start
  App->>App: SetPreBlocker(...)
  App->>App: PreBlocker(ctx, reqFinalizeBlock)
  end

  rect rgb(245,240,245)
  note over App: New flow (after this change)
  Node->>App: InitChain/Start
  App--xApp: No SetPreBlocker
  App--xApp: PreBlocker method removed
  end

  rect rgb(240,250,245)
  note over Upgrader: Upgrade key change
  App->>Upgrader: SetUpgradeHandler("v0.7.1", handler)
  end
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

protocol

Suggested reviewers

  • mn13
  • ijonele
  • Svetomech

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title concisely and accurately summarizes the primary change of enabling the Slinky pre-blocker in the oracle module, making it clear to reviewers what feature is being implemented without extraneous detail.
Description Check ✅ Passed The pull request description clearly states the key changes to enable the slinky pre-blocker for on-chain price recording and mentions preparation for the v0.7.1 upgrade, matching the actual file changes and objectives of the PR.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch enable-slinky-preblocker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d8af5b2 and f495468.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • CHANGELOG.md (1 hunks)
  • cmd/wardend/config/wardend_config.go (1 hunks)
  • go.mod (0 hunks)
  • warden/app/app.go (1 hunks)
💤 Files with no reviewable changes (1)
  • go.mod
🧰 Additional context used
📓 Path-based instructions (1)
**/*.md

⚙️ CodeRabbit configuration file

**/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

Files:

  • CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: lint
  • GitHub Check: test
  • GitHub Check: test
  • GitHub Check: lint
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
warden/app/app.go (1)

879-881: LGTM! Upgrade handler correctly updated to v0.7.1.

The upgrade handler key has been properly updated from "v0.7.0" to "v0.7.1", which aligns with the changelog entry and PR objectives. The migration logic correctly invokes RunMigrations to handle module version updates.

cmd/wardend/config/wardend_config.go (1)

24-25: LGTM – import path verified. The new import github.com/warden-protocol/connect/oracle/config is present in go.mod at v1.3.0 and supplies the expected oracleconfig.AppConfig type.

@Pitasi Pitasi merged commit 63c4696 into main Oct 9, 2025
19 checks passed
@Pitasi Pitasi deleted the enable-slinky-preblocker branch October 9, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments