Fix all specs and deprecation warnings for Crystal 0.31.1#43
Open
ndbroadbent wants to merge 3 commits intowaterlink:masterfrom
Open
Fix all specs and deprecation warnings for Crystal 0.31.1#43ndbroadbent wants to merge 3 commits intowaterlink:masterfrom
ndbroadbent wants to merge 3 commits intowaterlink:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed all the specs and deprecation warnings for Crystal 0.31.1:
Changes:
Fix Arithmetic overflow (OverflowError) in the hash calculations
Crystal added new "wrapping" arithmetic operators in
0.27.0, and the hash calculations now raise an OverflowError unless these are used.Fix
Time.nowdeprecationTime.nowwas deprecated in Crystal 0.28.0, and needs to be replaced withTime.local.Need to mock
Crystal::System::File.exists?(Not sure when this changed, or if it's related to other changes in the Crystal language.)
So I updated the test to mock
Crystal::System::File, which fixes the failing test. (But maybe this is just a temporary workaround.)Original PRs: