[ITEM-101] Add connector configuration and packaging#184
Open
ja0x wants to merge 2 commits intofeat/mc-2-infrastructurefrom
Open
[ITEM-101] Add connector configuration and packaging#184ja0x wants to merge 2 commits intofeat/mc-2-infrastructurefrom
ja0x wants to merge 2 commits intofeat/mc-2-infrastructurefrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3078469. Configure here.
ja0x
force-pushed
the
feat/mc-2-infrastructure
branch
from
37582fb to
f065e0e
Compare
ja0x
force-pushed
the
feat/mc-2-infrastructure
branch
from
f065e0e to
39fc0c6
Compare
ja0x
force-pushed
the
feat/mc-2-infrastructure
branch
from
39fc0c6 to
c3004a0
Compare
ja0x
force-pushed
the
feat/mc-2-infrastructure
branch
from
1dbed3d to
77e3659
Compare
SQLAlchemy's asyncpg dialect forwards URI query params as kwargs to asyncpg.connect(). application_name is a Postgres GUC, not an asyncpg kwarg, which made the connector fail to connect in production with "connect() got an unexpected keyword argument 'application_name'". Consolidate URI parsing into a single _build_async_engine_args helper that translates sslmode into an ssl bool and routes known Postgres GUCs through server_settings.
Add connector-related config keys (delivery, connectors, initialization). Wire PluginDependencies TypedDict and Hooks into controller. Add asyncpg dependency. Register connectors plugin entry point.
|
rbienvenu0
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_concurrent_tasks,provider_cache_ttlconnectorsandinitialization.token_expirationconfig sectionsPluginDependencies,Hooks, andbus_publisherinto controllerasyncpgto requirements and debian dependenciesconnectorsplugin entry point in setup.pyTest plan
Note
Medium Risk
Introduces new plugin/config surfaces and changes async DB connection argument parsing, which could affect startup and database connectivity across environments if URIs include uncommon query params.
Overview
Adds first-class connector support: enables the
roomsplugin by default in sample config, introduces a newconnectorsconfiguration section, and registers a newconnectorsplugin entry point.Extends runtime wiring by adding a shared
DAOinstance and a newHooksdispatcher into the plugin dependency injection, and refactors controller lifecycle management to useExitStack.Updates async Postgres handling to use
asyncpg, including packaging/dependencies (requirements.txt,debian/control) and improved URI parsing that mapssslmodeand selected Postgres GUCs intoconnect_args/server_settings(with expanded unit tests).Reviewed by Cursor Bugbot for commit 2802234. Bugbot is set up for automated code reviews on this repo. Configure here.