enhance: revamp registration template 1 #1723
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -53,4 +53,4 @@ tests/chrome_recordings | |
| *.min.js.* | ||
| *.min.css.* | ||
| tests/e2e/plugins-page-wpuf-lite-check.png | ||
| tests/e2e/screenshots | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,10 +2,11 @@ | |
|
|
||
| namespace WeDevs\Wpuf; | ||
|
|
||
| use WeDevs\Wpuf\Admin\Forms\Form; | ||
| use WeDevs\Wpuf\Admin\Subscription; | ||
|
|
||
| class Frontend_Render_Form { | ||
| private static $_instance; | ||
|
|
||
| public static $meta_key = 'wpuf_form'; | ||
|
|
||
|
|
@@ -123,7 +124,7 @@ | |
| wp_send_json_error( __( 'Unauthorized operation', 'wp-user-frontend' ) ); | ||
| } | ||
|
|
||
| $form_id = isset( $_GET['form_id'] ) ? intval( wp_unslash( $_GET['form_id'] ) ) : 0; | ||
|
Check warning on line 127 in includes/Frontend_Render_Form.php
|
||
|
|
||
| if ( $form_id ) { | ||
| wp_enqueue_script( 'jquery' ); | ||
|
|
@@ -197,15 +198,50 @@ | |
|
|
||
| $label_position = isset( $this->form_settings['label_position'] ) ? $this->form_settings['label_position'] : 'left'; | ||
|
|
||
| $layout = 'layout1'; | ||
|
|
||
| $theme_css = isset( $this->form_settings['use_theme_css'] ) ? $this->form_settings['use_theme_css'] : 'wpuf-style'; | ||
|
Comment on lines
+201
to
203
There was a problem hiding this comment. “Use Theme CSS” emits raw setting as a CSS class and is layout-inconsistent. Currently the class attribute may become “on/off” (or similar), and esc_html is used in a class attribute. Compute a boolean and derive the skin class; use esc_attr. Apply a minimal fix by computing the class at render-time: <?php
$skin_class = ( 'layout1' === $layout )
? ( isset( $this->form_settings['use_theme_css'] ) && wpuf_is_checkbox_or_toggle_on( $this->form_settings['use_theme_css'] ) ? '' : 'wpuf-style' )
: 'wpuf-style';
?>
<form class="wpuf-form-add wpuf-form-<?php echo esc_attr( $layout ); ?> <?php echo esc_attr( $skin_class ); ?>" action="" method="post">Optional cleanup: remove the now-unused $theme_css variable. Also applies to: 261-263 |
||
|
|
||
| do_action( 'wpuf_before_form_render', $form_id ); | ||
|
|
||
| $form = new Form($form_id); | ||
|
|
||
| // Check if Use Theme CSS is enabled - if so, don't enqueue plugin styles | ||
| $use_theme_css = isset( $this->form_settings['use_theme_css'] ) ? $this->form_settings['use_theme_css'] : ''; | ||
|
|
||
| if ( 'wpuf_profile' === $form->data->post_type && 'on' !== $use_theme_css ) { | ||
| $layout = isset( $this->form_settings['profile_form_layout'] ) ? $this->form_settings['profile_form_layout'] : 'layout1'; | ||
| switch ( $layout ) { | ||
| case 'layout2': | ||
| wp_enqueue_style( 'wpuf-reg-template-2' ); | ||
| break; | ||
|
|
||
| case 'layout3': | ||
| wp_enqueue_style( 'wpuf-reg-template-3' ); | ||
| break; | ||
|
|
||
| case 'layout4': | ||
| wp_enqueue_style( 'wpuf-reg-template-4' ); | ||
| break; | ||
|
|
||
| case 'layout5': | ||
| wp_enqueue_style( 'wpuf-reg-template-5' ); | ||
| break; | ||
|
|
||
| default: | ||
| wp_enqueue_style( 'wpuf-reg-template-1' ); | ||
| break; | ||
| } | ||
| } else { | ||
| $layout = isset( $this->form_settings['form_layout'] ) ? $this->form_settings['form_layout'] : 'layout1'; | ||
|
|
||
| if ( ! empty( $layout ) && 'on' !== $use_theme_css ) { | ||
| // Always enqueue the base template style | ||
| wp_enqueue_style( 'wpuf-reg-template-base' ); | ||
| wp_enqueue_style( 'wpuf-' . $layout ); | ||
| } | ||
| } | ||
|
|
||
| if ( ! is_user_logged_in() && ( ! empty( $this->form_settings['post_permission'] ) && 'guest_post' !== $this->form_settings['post_permission'] ) ) { | ||
| $login = wpuf()->frontend->simple_login->get_login_url(); | ||
| $register = wpuf()->frontend->simple_login->get_registration_url(); | ||
|
|
@@ -328,8 +364,8 @@ | |
| </div> | ||
| <div > | ||
| <label > | ||
| <input type="checkbox" class="wpuf_is_featured" name="is_featured_item" value="1" <?php echo $is_featured ? 'checked' : ''; ?> > | ||
| <span class="wpuf-items-table-containermessage-box" id="remaining-feature-item"> <?php echo sprintf( | ||
| // translators: %1$s is Post type and %2$d is item | ||
| wp_kses_post( __( 'Mark the %1$s as featured (remaining %2$d)', 'wp-user-frontend' ) ), esc_html( $post_type ), esc_html( $featured_item ) ); ?></span> | ||
| </label> | ||
|
|
@@ -365,7 +401,7 @@ | |
|
|
||
| foreach ( $form_vars as $key => $value ) { | ||
| // get column field input fields | ||
| if ( $value['input_type'] == 'column_field' ) { | ||
| $inner_fields = $value['inner_fields']; | ||
|
|
||
| foreach ( $inner_fields as $column_key => $column_fields ) { | ||
|
|
@@ -377,12 +413,12 @@ | |
| } | ||
|
|
||
| //separate the post and custom fields | ||
| if ( isset( $column_field['is_meta'] ) && $column_field['is_meta'] == 'yes' ) { | ||
| $meta_vars[] = $column_field; | ||
| continue; | ||
| } | ||
|
|
||
| if ( $column_field['input_type'] == 'taxonomy' ) { | ||
|
|
||
| // don't add "category" | ||
| // if ( $column_field['name'] == 'category' ) { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -251,7 +251,7 @@ public function render_form( $form_id, $post_id = null ) { | |
|
|
||
| do_action( 'wpuf_before_form_render', $form_id ); | ||
|
|
||
| if ( ! empty( $layout ) && 'on' !== $theme_css ) { | ||
| wp_enqueue_style( 'wpuf-' . $layout ); | ||
| } | ||
|
|
||
|
|
@@ -1334,12 +1334,12 @@ private function is_taxonomy_field_gated( $form_field ) { | |
| if ( $form_field['input_type'] !== 'taxonomy' ) { | ||
| return false; | ||
| } | ||
|
|
||
| // If pro is active, no fields are gated | ||
| if ( wpuf_is_pro_active() ) { | ||
| return false; | ||
| } | ||
|
|
||
| // Check if this is a custom taxonomy | ||
| $builtin_taxonomies = apply_filters( 'wpuf_builtin_taxonomies_free', array( 'category', 'post_tag' ) ); | ||
| return ! in_array( $form_field['name'], $builtin_taxonomies, true ); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -779,7 +779,7 @@ msgstr "" | |
|
|
||
| #: admin/html/form-settings-post.php:22 class/render-form.php:776 | ||
| #: includes/Admin/Forms/Admin_Form_Builder.php:83 | ||
| #: includes/Frontend_Render_Form.php:80 includes/Render_Form.php:638 | ||
| #: includes/class-frontend-render-form.php:183 | ||
| msgid "Save Draft" | ||
| msgstr "" | ||
|
|
@@ -1207,7 +1207,7 @@ msgstr "" | |
| #: includes/Ajax/Admin_Form_Builder_Ajax.php:138 | ||
| #: includes/Ajax/Admin_Form_Builder_Ajax.php:142 | ||
| #: includes/Ajax/Admin_Form_Builder_Ajax.php:218 | ||
| #: includes/Frontend_Render_Form.php:124 | ||
| #: includes/Integrations/WPUF_ACF_Compatibility.php:76 | ||
| #: includes/Integrations/WPUF_ACF_Compatibility.php:94 | ||
| #: includes/Integrations/WPUF_ACF_Compatibility.php:160 | ||
|
|
@@ -1255,7 +1255,7 @@ msgstr "" | |
| #: admin/template-post.php:150 includes/Admin/Forms/Template_Post.php:159 | ||
| #: includes/Fields/Field_Contract.php:494 | ||
| #: includes/Fields/Form_Field_MultiDropdown.php:11 | ||
| #: includes/Fields/Form_Field_MultiDropdown.php:84 | ||
| msgid "Multi Select" | ||
| msgstr "" | ||
|
|
||
|
|
@@ -1676,12 +1676,12 @@ msgstr "" | |
| msgid "Invisible reCAPTCHA validation failed" | ||
| msgstr "" | ||
|
|
||
| #: class/render-form.php:378 includes/Frontend_Render_Form.php:188 | ||
| #: includes/Render_Form.php:235 includes/class-frontend-render-form.php:289 | ||
| msgid "Your selected form is no longer available." | ||
| msgstr "" | ||
|
|
||
| #: class/render-form.php:384 includes/Frontend_Render_Form.php:194 | ||
| #: includes/Render_Form.php:241 includes/class-frontend-render-form.php:295 | ||
| msgid "Please make sure you've published your form." | ||
| msgstr "" | ||
|
|
@@ -2898,7 +2898,7 @@ msgstr "" | |
| #: includes/Admin/Forms/Post/Templates/Post_Form_Template_Video.php:104 | ||
| #: includes/Fields/Field_Contract.php:238 | ||
| #: includes/Fields/Form_Field_Dropdown.php:110 | ||
| #: includes/Fields/Form_Field_MultiDropdown.php:88 | ||
| #: includes/Fields/Form_Field_Post_Taxonomy.php:500 | ||
| msgid "- Select -" | ||
| msgstr "" | ||
|
|
@@ -2939,7 +2939,7 @@ msgstr "" | |
| #: includes/Admin/Forms/Admin_Form_Builder.php:336 | ||
| #: includes/Fields/Form_Field_Checkbox.php:112 | ||
| #: includes/Fields/Form_Field_Dropdown.php:109 | ||
| #: includes/Fields/Form_Field_MultiDropdown.php:87 | ||
| #: includes/Fields/Form_Field_Radio.php:111 | ||
| msgid "Option" | ||
| msgstr "" | ||
|
|
@@ -4731,7 +4731,7 @@ msgid "You already have an account in our site. Please login to continue." | |
| msgstr "" | ||
|
|
||
| #: includes/Ajax/Frontend_Form_Ajax.php:752 | ||
| #: includes/Frontend_Render_Form.php:258 | ||
| #: includes/class-frontend-render-form.php:323 | ||
| msgid "You do not have sufficient permissions to access this form." | ||
| msgstr "" | ||
|
|
@@ -6921,13 +6921,13 @@ msgstr "" | |
| msgid "Please Cancel Your Currently Active Pack first!" | ||
| msgstr "" | ||
|
|
||
| #: includes/Frontend_Render_Form.php:358 | ||
| #: includes/class-frontend-render-form.php:928 | ||
| #: templates/dashboard/posts.php:120 | ||
| msgid "Featured" | ||
| msgstr "" | ||
|
|
||
| #: includes/Frontend_Render_Form.php:365 | ||
| #: includes/class-frontend-render-form.php:936 | ||
| #. translators: %1$s is Post type and %2$d is item | ||
| #. translators: %1$s is Post type and %2$s is total feature item | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Asset enqueue is good; ensure handle exists and admin preview needs
Looks good for frontend. Verify the 'wpuf-custom-multiselect' handle is registered and consider enqueueing on form preview pages in admin if the builder preview relies on it.
🏁 Script executed:
Length of output: 544
🏁 Script executed:
Length of output: 670
🏁 Script executed:
Length of output: 1545
🏁 Script executed:
Length of output: 3573
🏁 Script executed:
Length of output: 13540
🏁 Script executed:
Length of output: 0
🏁 Script executed:
Length of output: 108
Register 'wpuf-custom-multiselect' handle before enqueueing
The script handle 'wpuf-custom-multiselect' is being enqueued at includes/Fields/Form_Field_MultiDropdown.php:187 but is not registered anywhere in the codebase. Register it in Assets.php via the
get_scripts()method with the appropriate source file and dependencies, or the asset will fail to load.Additionally, consider whether this script needs to be enqueued on admin form preview/builder pages if the preview relies on it (currently only enqueued on frontend via
if ( ! is_admin() )).🤖 Prompt for AI Agents