Rails 7

[em-cd]

This brings us up to Rails 7! 🎉

[codecov]

Codecov Report

Merging #256 (b0dcc3d) into master (255432a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   78.56%   78.56%           
=======================================
  Files         167      166    -1     
  Lines        3000     3000           
=======================================
  Hits         2357     2357           
  Misses        643      643           

Impacted Files	Coverage Δ
config/initializers/doorkeeper.rb	44.44% <ø> (ø)
app/mailers/service_mailer.rb	37.50% <100.00%> (+4.16%)	⬆️
app/models/note.rb	100.00% <100.00%> (ø)
app/serializers/regular_schedule_serializer.rb	100.00% <100.00%> (ø)
config/application.rb	100.00% <100.00%> (ø)
config/environments/test.rb	100.00% <100.00%> (ø)
config/initializers/devise.rb	100.00% <100.00%> (ø)
spec/features/using_custom_fields_spec.rb	100.00% <100.00%> (ø)
app/models/ofsted_item.rb	57.89% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[apricot13]

I got one error on my tests but I'm not sure if my outpost is setup correctly yet!

Failures:

  1) Using custom fields as a user manager I can create and use custom fields for services
     Failure/Error: click_link custom_field_section.name

     Capybara::ElementNotFound:
       Unable to find link "Quia ratione dolor fugiat."
     # ./spec/features/using_custom_fields_spec.rb:18:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:123:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:122:in `block (2 levels) in <top (required)>'

Finished in 21.33 seconds (files took 2.25 seconds to load)
104 examples, 1 failure

Failed examples:

rspec ./spec/features/using_custom_fields_spec.rb:11 # Using custom fields as a user manager I can create and use custom fields for services

[em-cd]

I got one error on my tests but I'm not sure if my outpost is setup correctly yet!

Failures:

  1) Using custom fields as a user manager I can create and use custom fields for services
     Failure/Error: click_link custom_field_section.name

     Capybara::ElementNotFound:
       Unable to find link "Quia ratione dolor fugiat."
     # ./spec/features/using_custom_fields_spec.rb:18:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:123:in `block (3 levels) in <top (required)>'
     # ./spec/spec_helper.rb:122:in `block (2 levels) in <top (required)>'

Finished in 21.33 seconds (files took 2.25 seconds to load)
104 examples, 1 failure

Failed examples:

rspec ./spec/features/using_custom_fields_spec.rb:11 # Using custom fields as a user manager I can create and use custom fields for services

I've tried tweaking the test in case it's a weird JS/FactoryBot issue, can you try running it again to see if that fixes it?

[apricot13]

other than the issue with the url_for section all works for me!

<%= image_tag(url_for(FileUpload.find_by(var: 'outpost_logo').file), alt: Setting.outpost_title, class: "site-header__logo") %>

[apricot13]

Came across a few bugs in the containerisation work - this was using ruby 3.0.5 not 3.0.3

• rails c error - need to update spring more info here
• Unsure if its a rails issue with the change in how files are brought in or a docker issue but the tests weren't recognising the factories