Fix docker image issues#286
Closed
cpcundill wants to merge 3 commits intowearefuturegov:fix/tower-revertfrom
Closed
Fix docker image issues#286cpcundill wants to merge 3 commits intowearefuturegov:fix/tower-revertfrom
cpcundill wants to merge 3 commits intowearefuturegov:fix/tower-revertfrom
Conversation
…to Greenwich app platform which uses k8s
Member
|
hey @cpcundill I've rolled your changes into #287 I've also managed to fix one of the additional package.json requirements so only one extra package was required! 🎉 I'm going to close this PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for issues found with docker image when tested on Greenwich's app platform which uses k8s