fix: use WdioIcsOptions for wdio-ics:options type augmentation#1122
Merged
wswebcreation merged 1 commit intomainfrom Feb 24, 2026
Merged
fix: use WdioIcsOptions for wdio-ics:options type augmentation#1122wswebcreation merged 1 commit intomainfrom
wswebcreation merged 1 commit intomainfrom
Conversation
The global type augmentation for `wdio-ics:options` on `WebdriverIO.Capabilities` was using an incomplete inline type with only `logName`. This replaces it with the `WdioIcsOptions` interface which includes all supported properties (`logName` and `name`), fixing TypeScript errors for users in both standalone and multiremote configurations. Fixes #732 Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: db82d6d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wdio-ics:optionstype augmentation onWebdriverIO.Capabilitiesby using theWdioIcsOptionsinterface instead of an inline type with onlylogNamelogName,name) are available to TypeScript users in both standalone and multiremote configurationswdio-ics:optionsworkaround fromtests/types/wdio.d.tssince the proper augmentation now covers itFixes #732